Commit c1bcdbc
authored
build: warn for gcc versions earlier than 10.1
Update the warning threshold for gcc to 10.1 starting from Node.js 20.
Builds can still proceed with earlier versions of gcc, but are not
guaranteed to work.
PR-URL: #46806
Refs: https://github.com/nodejs/node/discussions/45892
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 78b911d commit c1bcdbc
2 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -152,7 +152,7 @@ Depending on the host platform, the selection of toolchains may vary. | |||
| 152 | 152 | ||
| 153 | 153 | | Operating System | Compiler Versions | | |
| 154 | 154 | | ---------------- | -------------------------------------------------------------- | | |
| 155 | - | Linux | GCC >= 8.3 | | ||
| 155 | + | Linux | GCC >= 10.1 | | ||
| 156 | 156 | | Windows | Visual Studio >= 2019 with the Windows 10 SDK on a 64-bit host | | |
| 157 | 157 | | macOS | Xcode >= 11 (Apple LLVM >= 11) | | |
| 158 | 158 | ||
@@ -223,7 +223,7 @@ The Node.js project supports Python >= 3 for building and testing. | |||
| 223 | 223 | ||
| 224 | 224 | #### Unix prerequisites | |
| 225 | 225 | ||
| 226 | - * `gcc` and `g++` >= 8.3 or newer | ||
| 226 | + * `gcc` and `g++` >= 10.1 or newer | ||
| 227 | 227 | * GNU Make 3.81 or newer | |
| 228 | 228 | * Python >=3.6 <=3.11 (see note above) | |
| 229 | 229 | * For test coverage, your Python installation must include pip. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1032,8 +1032,8 @@ def check_compiler(o): | |||
| 1032 | 1032 | ('clang ' if is_clang else '', CXX, version_str)) | |
| 1033 | 1033 | if not ok: | |
| 1034 | 1034 | warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX) | |
| 1035 | - elif clang_version < (8, 0, 0) if is_clang else gcc_version < (8, 3, 0): | ||
| 1036 | - warn('C++ compiler (CXX=%s, %s) too old, need g++ 8.3.0 or clang++ 8.0.0' % | ||
| 1035 | + elif clang_version < (8, 0, 0) if is_clang else gcc_version < (10, 1, 0): | ||
| 1036 | + warn('C++ compiler (CXX=%s, %s) too old, need g++ 10.1.0 or clang++ 8.0.0' % | ||
| 1037 | 1037 | (CXX, version_str)) | |
| 1038 | 1038 | ||
| 1039 | 1039 | ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c') | |
0 commit comments