Commit c245a19
lib: fix undefined timeout regression
63644dd introduced a regression caused by everyone's favourite
JavaScript feature: undefined < 0 === undefined >= 0.
Add a case to the existing tests to cover this scenario and then add
the check for undefined that makes the test pass.
PR-URL: #3331
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed By: Evan Lucas <evanlucas@me.com>1 parent b3cbd13 commit c245a19
2 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -30,7 +30,7 @@ var lists = {}; | |||
| 30 | 30 | // with them. | |
| 31 | 31 | exports.active = function(item) { | |
| 32 | 32 | const msecs = item._idleTimeout; | |
| 33 | - if (msecs < 0) return; | ||
| 33 | + if (msecs < 0 || msecs === undefined) return; | ||
| 34 | 34 | ||
| 35 | 35 | item._idleStart = Timer.now(); | |
| 36 | 36 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -22,7 +22,8 @@ legitTimers.forEach(function(legit) { | |||
| 22 | 22 | ||
| 23 | 23 | // active() should not create a timer for these | |
| 24 | 24 | var bogusTimers = [ | |
| 25 | - { _idleTimeout: -1 } | ||
| 25 | + { _idleTimeout: -1 }, | ||
| 26 | + { _idleTimeout: undefined }, | ||
| 26 | 27 | ]; | |
| 27 | 28 | ||
| 28 | 29 | bogusTimers.forEach(function(bogus) { | |
0 commit comments