| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent ba5683c commit c2757d1
3 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1659,6 +1659,10 @@ the request body should be sent. | |||
| 1659 | 1659 | ## Class: `http.IncomingMessage` | |
| 1660 | 1660 | <!-- YAML | |
| 1661 | 1661 | added: v0.1.17 | |
| 1662 | + changes: | ||
| 1663 | + - version: REPLACEME | ||
| 1664 | + pr-url: https://github.com/nodejs/node/pull/30135 | ||
| 1665 | + description: The `readableHighWaterMark` value mirrors that of the socket. | ||
| 1662 | 1666 | --> | |
| 1663 | 1667 | ||
| 1664 | 1668 | * Extends: {stream.Readable} | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,15 @@ function readStop(socket) { | |||
| 37 | 37 | ||
| 38 | 38 | /* Abstract base class for ServerRequest and ClientResponse. */ | |
| 39 | 39 | function IncomingMessage(socket) { | |
| 40 | - Stream.Readable.call(this); | ||
| 40 | + let streamOptions; | ||
| 41 | + | ||
| 42 | + if (socket) { | ||
| 43 | + streamOptions = { | ||
| 44 | + highWaterMark: socket.readableHighWaterMark | ||
| 45 | + }; | ||
| 46 | + } | ||
| 47 | + | ||
| 48 | + Stream.Readable.call(this, streamOptions); | ||
| 41 | 49 | ||
| 42 | 50 | this._readableState.readingMore = true; | |
| 43 | 51 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,24 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + const common = require('../common'); | ||
| 3 | + const assert = require('assert'); | ||
| 4 | + const http = require('http'); | ||
| 5 | + const net = require('net'); | ||
| 6 | + const readableHighWaterMark = 1024; | ||
| 7 | + const server = http.createServer((req, res) => { res.end(); }); | ||
| 8 | + | ||
| 9 | + server.listen(0, common.mustCall(() => { | ||
| 10 | + const req = http.request({ | ||
| 11 | + port: server.address().port, | ||
| 12 | + createConnection(options) { | ||
| 13 | + options.readableHighWaterMark = readableHighWaterMark; | ||
| 14 | + return net.createConnection(options); | ||
| 15 | + } | ||
| 16 | + }, common.mustCall((res) => { | ||
| 17 | + assert.strictEqual(res.socket, req.socket); | ||
| 18 | + assert.strictEqual(res.socket.readableHighWaterMark, readableHighWaterMark); | ||
| 19 | + assert.strictEqual(res.readableHighWaterMark, readableHighWaterMark); | ||
| 20 | + server.close(); | ||
| 21 | + })); | ||
| 22 | + | ||
| 23 | + req.end(); | ||
| 24 | + })); | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments