Commit c27f3cf
build: add --enable-all-experimentals build flag
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
PR-URL: #62755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent e850ee9 commit c27f3cf
3 files changed
Lines changed: 26 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -15,6 +15,7 @@ | |||
| 15 | 15 | 'python%': 'python', | |
| 16 | 16 | ||
| 17 | 17 | 'node_shared%': 'false', | |
| 18 | + 'node_enable_experimentals%': 'false', | ||
| 18 | 19 | 'force_dynamic_crt%': 0, | |
| 19 | 20 | 'node_use_v8_platform%': 'true', | |
| 20 | 21 | 'node_use_bundled_v8%': 'true', | |
@@ -437,6 +438,9 @@ | |||
| 437 | 438 | }], | |
| 438 | 439 | # The defines bellow must include all things from the external_v8_defines | |
| 439 | 440 | # list in v8/BUILD.gn. | |
| 441 | + ['node_enable_experimentals == "true"', { | ||
| 442 | + 'defines': ['EXPERIMENTALS_DEFAULT_VALUE=true'], | ||
| 443 | + }], | ||
| 440 | 444 | ['v8_enable_v8_checks == 1', { | |
| 441 | 445 | 'defines': ['V8_ENABLE_CHECKS'], | |
| 442 | 446 | }], | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -797,6 +797,12 @@ | |||
| 797 | 797 | default=None, | |
| 798 | 798 | help='Enable the --trace-maps flag in V8 (use at your own risk)') | |
| 799 | 799 | ||
| 800 | + parser.add_argument('--enable-all-experimentals', | ||
| 801 | + action='store_true', | ||
| 802 | + dest='enable_all_experimentals', | ||
| 803 | + default=None, | ||
| 804 | + help='Enable all experimental features by default') | ||
| 805 | + | ||
| 800 | 806 | parser.add_argument('--experimental-enable-pointer-compression', | |
| 801 | 807 | action='store_true', | |
| 802 | 808 | dest='enable_pointer_compression', | |
@@ -1803,6 +1809,7 @@ def configure_node_cctest_sources(o): | |||
| 1803 | 1809 | def configure_node(o): | |
| 1804 | 1810 | if options.dest_os == 'android': | |
| 1805 | 1811 | o['variables']['OS'] = 'android' | |
| 1812 | + o['variables']['node_enable_experimentals'] = b(options.enable_all_experimentals) | ||
| 1806 | 1813 | o['variables']['node_prefix'] = options.prefix | |
| 1807 | 1814 | o['variables']['node_install_npm'] = b(not options.without_npm) | |
| 1808 | 1815 | o['variables']['node_install_corepack'] = b(options.with_corepack) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -112,6 +112,10 @@ class DebugOptions : public Options { | |||
| 112 | 112 | std::vector<std::string>* argv) override; | |
| 113 | 113 | }; | |
| 114 | 114 | ||
| 115 | + #ifndef EXPERIMENTALS_DEFAULT_VALUE | ||
| 116 | + #define EXPERIMENTALS_DEFAULT_VALUE false | ||
| 117 | + #endif | ||
| 118 | + | ||
| 115 | 119 | class EnvironmentOptions : public Options { | |
| 116 | 120 | public: | |
| 117 | 121 | bool abort_on_uncaught_exception = false; | |
@@ -122,18 +126,18 @@ class EnvironmentOptions : public Options { | |||
| 122 | 126 | bool require_module = true; | |
| 123 | 127 | std::string dns_result_order; | |
| 124 | 128 | bool enable_source_maps = false; | |
| 125 | - bool experimental_addon_modules = false; | ||
| 126 | - bool experimental_eventsource = false; | ||
| 127 | - bool experimental_ffi = false; | ||
| 129 | + bool experimental_addon_modules = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 130 | + bool experimental_eventsource = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 131 | + bool experimental_ffi = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 128 | 132 | bool experimental_websocket = true; | |
| 129 | 133 | bool experimental_sqlite = HAVE_SQLITE; | |
| 130 | - bool experimental_stream_iter = false; | ||
| 134 | + bool experimental_stream_iter = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 131 | 135 | bool webstorage = HAVE_SQLITE; | |
| 132 | - bool experimental_quic = false; | ||
| 136 | + bool experimental_quic = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 133 | 137 | std::string localstorage_file; | |
| 134 | 138 | bool experimental_global_navigator = true; | |
| 135 | 139 | bool experimental_global_web_crypto = true; | |
| 136 | - bool experimental_import_meta_resolve = false; | ||
| 140 | + bool experimental_import_meta_resolve = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 137 | 141 | std::string input_type; // Value of --input-type | |
| 138 | 142 | bool entry_is_url = false; | |
| 139 | 143 | bool permission = false; | |
@@ -148,7 +152,7 @@ class EnvironmentOptions : public Options { | |||
| 148 | 152 | bool allow_ffi = false; | |
| 149 | 153 | bool allow_worker_threads = false; | |
| 150 | 154 | bool experimental_repl_await = true; | |
| 151 | - bool experimental_vm_modules = false; | ||
| 155 | + bool experimental_vm_modules = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 152 | 156 | bool async_context_frame = true; | |
| 153 | 157 | bool expose_internals = false; | |
| 154 | 158 | bool force_node_api_uncaught_exceptions_policy = false; | |
@@ -175,10 +179,10 @@ class EnvironmentOptions : public Options { | |||
| 175 | 179 | uint64_t cpu_prof_interval = kDefaultCpuProfInterval; | |
| 176 | 180 | std::string cpu_prof_name; | |
| 177 | 181 | bool cpu_prof = false; | |
| 178 | - bool experimental_network_inspection = false; | ||
| 179 | - bool experimental_worker_inspection = false; | ||
| 180 | - bool experimental_storage_inspection = false; | ||
| 181 | - bool experimental_inspector_network_resource = false; | ||
| 182 | + bool experimental_network_inspection = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 183 | + bool experimental_worker_inspection = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 184 | + bool experimental_storage_inspection = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 185 | + bool experimental_inspector_network_resource = EXPERIMENTALS_DEFAULT_VALUE; | ||
| 182 | 186 | std::string heap_prof_dir; | |
| 183 | 187 | std::string heap_prof_name; | |
| 184 | 188 | static const uint64_t kDefaultHeapProfInterval = 512 * 1024; | |
0 commit comments