test: replace forEach with for of in file test-trace-events-net.js · nodejs/node@c3c2b2b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c3c2b2b

Browse filesBrowse the repository at this point in the historyBrowse files

Ianna83

authored and

richardlau

committed

test: replace forEach with for of in file test-trace-events-net.js

PR-URL: #50789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 55c423b commit c3c2b2b
Copy full SHA for c3c2b2b

1 file changed

+3-4Lines changed: 3 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-trace-events-net.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-trace-events-net.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-trace-events-net.js

+3-4Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -32,12 +32,11 @@ proc.once('exit', common.mustCall(() => {
32	32	const traces = JSON.parse(data.toString()).traceEvents;
33	33	assert(traces.length > 0);
34	34	let count = 0;
35		- traces.forEach((trace) => {
36		- if (trace.cat === 'node,node.net,node.net.native' &&
37		- trace.name === 'connect') {
	35	+ for (const trace of traces) {
	36	+ if (trace.cat === 'node,node.net,node.net.native' && trace.name === 'connect') {
38	37	count++;
39	38	}
40		- });
	39	+ }
41	40	// Two begin, two end
42	41	assert.strictEqual(count, 4);
43	42	}));

0 commit comments

Comments

0 (0)