Commit c4457d8
benchmark: always throw the same Error instance
Stack trace capturing currently accounts for 40 % of the benchmark
running time. Always throwing the same exception object removes
that overhead and lets the benchmark be more focused on what it is
supposed to measure.
Refs: #34512 (comment)
PR-URL: #34523
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>1 parent 44e6c01 commit c4457d8
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,10 +37,11 @@ const bench = common.createBenchmark(main, { | |||
| 37 | 37 | ] | |
| 38 | 38 | }); | |
| 39 | 39 | ||
| 40 | + const err = new Error('foobar'); | ||
| 40 | 41 | async function run(n) { | |
| 41 | 42 | for (let i = 0; i < n; i++) { | |
| 42 | 43 | await new Promise((resolve) => resolve()) | |
| 43 | - .then(() => { throw new Error('foobar'); }) | ||
| 44 | + .then(() => { throw err; }) | ||
| 44 | 45 | .catch((e) => e); | |
| 45 | 46 | } | |
| 46 | 47 | } | |
0 commit comments