src: simplify enable_if logic of `ToStringHelper::BaseConvert` · nodejs/node@c5413a1 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c5413a1

Browse filesBrowse the repository at this point in the historyBrowse files

F3n67u

authored and

RafaelGSS

committed

src: simplify enable_if logic of ToStringHelper::BaseConvert

PR-URL: #44306 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

1 parent 11452a9 commit c5413a1
Copy full SHA for c5413a1

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • debug_utils-inl.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/debug_utils-inl.h‎

Copy file name to clipboardExpand all lines: src/debug_utils-inl.h

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -29,7 +29,7 @@ struct ToStringHelper {
29	29	static std::string Convert(bool value) { return value ? "true" : "false"; }
30	30	template <unsigned BASE_BITS,
31	31	typename T,
32		- typename std::enable_if<std::is_integral<T>::value, int>::type = 0>
	32	+ typename = std::enable_if_t<std::is_integral_v<T>>>
33	33	static std::string BaseConvert(const T& value) {
34	34	auto v = static_cast<uint64_t>(value);
35	35	char ret[3 * sizeof(T)];
@@ -45,7 +45,7 @@ struct ToStringHelper {
45	45	}
46	46	template <unsigned BASE_BITS,
47	47	typename T,
48		- typename std::enable_if<!std::is_integral<T>::value, int>::type = 0>
	48	+ typename = std::enable_if_t<!std::is_integral_v<T>>>
49	49	static std::string BaseConvert(T value) {
50	50	return Convert(std::forward<T>(value));
51	51	}

0 commit comments

Comments

0 (0)