test: fix `test-vm-context-dont-contextify` when path contains a space · nodejs/node@c56e324 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c56e324

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

targos

committed

test: fix test-vm-context-dont-contextify when path contains a space

Because of the double encoding, the test would fail as soon as the path contains a space or any other char that's already encoded by `pathToFileURL`. PR-URL: #55026 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent b6fc9ad commit c56e324
Copy full SHA for c56e324

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-vm-context-dont-contextify.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-vm-context-dont-contextify.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-vm-context-dont-contextify.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -176,7 +176,7 @@ function checkFrozen(context) {
176	176	const namespace = await import(moduleUrl.href);
177	177	// Check dynamic import works
178	178	const context = vm.createContext(vm.constants.DONT_CONTEXTIFY);
179		- const script = new vm.Script(`import('${encodeURI(moduleUrl.href)}')`, {
	179	+ const script = new vm.Script(`import(${JSON.stringify(moduleUrl)})`, {
180	180	importModuleDynamically: vm.constants.USE_MAIN_CONTEXT_DEFAULT_LOADER,
181	181	});
182	182	const promise = script.runInContext(context);

0 commit comments

Comments

0 (0)