Commit c5eb5bf
build: enable runtime linking
Enable runtime linking of shared objects. This will
allow loading of symbols using the RTLD_GLOBAL flag.
PR-URL: #15286
Fixes: #15243
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 3070d53 commit c5eb5bf
3 files changed
Lines changed: 3 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -784,7 +784,7 @@ | |||
| 784 | 784 | 'common.gypi', | |
| 785 | 785 | ], | |
| 786 | 786 | ||
| 787 | - 'ldflags': ['-Wl,-bE:<(PRODUCT_DIR)/node.exp'], | ||
| 787 | + 'ldflags': ['-Wl,-bE:<(PRODUCT_DIR)/node.exp', '-Wl,-brtl'], | ||
| 788 | 788 | }, | |
| 789 | 789 | { | |
| 790 | 790 | 'target_name': 'node_exp', | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -10,10 +10,9 @@ | |||
| 10 | 10 | 'xcode_settings': { | |
| 11 | 11 | 'OTHER_LDFLAGS': [ '-Wl,-undefined', '-Wl,dynamic_lookup' ] | |
| 12 | 12 | }}], | |
| 13 | - # Pass erok flag to the linker, to prevent unresolved symbols | ||
| 14 | - # from failing. Still, the test won't pass, so we'll skip it on AIX. | ||
| 13 | + # Enable the shared object to be linked by runtime linker | ||
| 15 | 14 | ['OS=="aix"', { | |
| 16 | - 'ldflags': [ '-Wl,-berok' ] | ||
| 15 | + 'ldflags': [ '-Wl,-G' ] | ||
| 17 | 16 | }]], | |
| 18 | 17 | }, | |
| 19 | 18 | { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,9 +4,6 @@ const common = require('../../common'); | |||
| 4 | 4 | if (common.isWindows) | |
| 5 | 5 | common.skip('dlopen global symbol loading is not supported on this os.'); | |
| 6 | 6 | ||
| 7 | - if (common.isAIX) | ||
| 8 | - common.skip('this test does not pass on AIX.'); | ||
| 9 | - | ||
| 10 | 7 | const assert = require('assert'); | |
| 11 | 8 | const path = require('path'); | |
| 12 | 9 | const os = require('os'); | |
0 commit comments