Commit c5f82b8
assert: fix deepEqual/deepStrictEqual on equivalent typed arrays
The typed array's underlying ArrayBuffer is used in `Buffer.from`.
Let's respect it's .byteOffset or .byteLength (i.e. position within the
parent ArrayBuffer).
Fixes: #8001
PR-URL: #8002
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 76245b2 commit c5f82b8
1 file changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -176,8 +176,13 @@ function _deepEqual(actual, expected, strict, memos) { | |||
| 176 | 176 | pToString(actual) === pToString(expected) && | |
| 177 | 177 | !(actual instanceof Float32Array || | |
| 178 | 178 | actual instanceof Float64Array)) { | |
| 179 | - return compare(new Buffer(actual.buffer), | ||
| 180 | - new Buffer(expected.buffer)) === 0; | ||
| 179 | + return compare( | ||
| 180 | + new Buffer(actual.buffer).slice(actual.byteOffset, | ||
| 181 | + actual.byteOffset + | ||
| 182 | + actual.byteLength), | ||
| 183 | + new Buffer(expected.buffer).slice(expected.byteOffset, | ||
| 184 | + expected.byteOffset + | ||
| 185 | + expected.byteLength)) === 0; | ||
| 181 | 186 | ||
| 182 | 187 | // 7.5 For all other Object pairs, including Array objects, equivalence is | |
| 183 | 188 | // determined by having the same number of owned properties (as verified | |
0 commit comments