Commit c60d87b
test: don't connect to :: (use localhost instead)
If a test does http.listen(0) or net.listen(0),
http.listen(0).address().address returns '::'. Some machines will
resolve this to localhost, but not all. Every machine should have
localhost defined in /etc/hosts (or equivalent), so it should always
resolve.
Fixes: #7291
PR-URL: #10854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>1 parent 3642f35 commit c60d87b
2 files changed
Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ function getall() { | |||
| 36 | 36 | if (count >= todo) | |
| 37 | 37 | return; | |
| 38 | 38 | ||
| 39 | - const req = net.connect(server.address().port, server.address().address); | ||
| 39 | + const req = net.connect(server.address().port); | ||
| 40 | 40 | req.resume(); | |
| 41 | 41 | req.setTimeout(10, function() { | |
| 42 | 42 | req.destroy(); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,7 +3,6 @@ | |||
| 3 | 3 | const common = require('../common'); | |
| 4 | 4 | const assert = require('assert'); | |
| 5 | 5 | const http = require('http'); | |
| 6 | - const net = require('net'); | ||
| 7 | 6 | ||
| 8 | 7 | function explicit(req, res) { | |
| 9 | 8 | assert.throws(() => { | |
@@ -34,8 +33,7 @@ const server = http.createServer((req, res) => { | |||
| 34 | 33 | implicit(req, res); | |
| 35 | 34 | } | |
| 36 | 35 | }).listen(0, common.mustCall(() => { | |
| 37 | - const addr = server.address().address; | ||
| 38 | - const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr; | ||
| 36 | + const hostname = 'localhost'; | ||
| 39 | 37 | const url = `http://${hostname}:${server.address().port}`; | |
| 40 | 38 | let left = 2; | |
| 41 | 39 | const check = common.mustCall((res) => { | |
0 commit comments