module: fix crash when built-in module export a `default` key · nodejs/node@c621491 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c621491

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

richardlau

committed

module: fix crash when built-in module export a default key

PR-URL: #51481 Fixes: #51480 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

1 parent 76968ab commit c621491
Copy full SHA for c621491

2 files changed

+11-1Lines changed: 11 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/bootstrap
  • realm.js
• test/parallel
  • test-process-default.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/bootstrap/realm.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/realm.js

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -350,7 +350,9 @@ class BuiltinModule {
350	350	const url = `node:${this.id}`;
351	351	const builtin = this;
352	352	const exportsKeys = ArrayPrototypeSlice(this.exportKeys);
353		- ArrayPrototypePush(exportsKeys, 'default');
	353	+ if (!ArrayPrototypeIncludes(exportsKeys, 'default')) {
	354	+ ArrayPrototypePush(exportsKeys, 'default');
	355	+ }
354	356	this.module = new ModuleWrap(
355	357	url, undefined, exportsKeys,
356	358	function() {

Collapse file

‎test/parallel/test-process-default.js‎

Copy file name to clipboard

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,8 @@
	1	+ 'use strict';
	2	+ const common = require('../common');
	3	+ const assert = require('node:assert');
	4	+
	5	+ process.default = 1;
	6	+ import('node:process').then(common.mustCall((processModule) => {
	7	+ assert.strictEqual(processModule.default.default, 1);
	8	+ }));

0 commit comments

Comments

0 (0)