crypto: fix error when getRandomValues is called without arguments · nodejs/node@c643645 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 762
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c643645

Browse filesBrowse the repository at this point in the historyBrowse files

panva

authored and

juanarbol

committed

crypto: fix error when getRandomValues is called without arguments

PR-URL: #45854 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

1 parent 5eb93f1 commit c643645
Copy full SHA for c643645

1 file changed

+3Lines changed: 3 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/crypto
  • random.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/crypto/random.js‎

Copy file name to clipboardExpand all lines: lib/internal/crypto/random.js

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -40,6 +40,7 @@ const { Buffer, kMaxLength } = require('buffer');
40	40	const {
41	41	codes: {
42	42	ERR_INVALID_ARG_TYPE,
	43	+ ERR_MISSING_ARGS,
43	44	ERR_OUT_OF_RANGE,
44	45	ERR_OPERATION_FAILED,
45	46	}
@@ -315,6 +316,8 @@ function onJobDone(buf, callback, error) {
315	316	// not allowed to exceed 65536 bytes, and can only
316	317	// be an integer-type TypedArray.
317	318	function getRandomValues(data) {
	319	+ if (arguments.length < 1)
	320	+ throw new ERR_MISSING_ARGS('typedArray');
318	321	if (!isTypedArray(data) ||
319	322	isFloat32Array(data) ||
320	323	isFloat64Array(data)) {

0 commit comments

Comments

0 (0)