build: fix 'gas_version' check on localized environments · nodejs/node@c688a00 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c688a00

Browse filesBrowse the repository at this point in the historyBrowse files

oliveiraev

authored and

targos

committed

build: fix 'gas_version' check on localized environments

Some GNU assembler versions got localized outputs like... ``` Gnu assembler versão 2.30 (x86_64-linux-gnu) usando versão BFD (GNU Binutils for Ubuntu) 2.30 ``` failing regex checker and the whole configure process. PR-URL: #20394 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 4757771 commit c688a00
Copy full SHA for c688a00

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• configure

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎configure‎

Copy file name to clipboardExpand all lines: configure

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -671,11 +671,13 @@ def get_xcode_version(cc):
671	671
672	672	def get_gas_version(cc):
673	673	try:
	674	+ custom_env = os.environ.copy()
	675	+ custom_env["LC_ALL"] = "en_US"
674	676	proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o',
675	677	'/dev/null', '-x',
676	678	'assembler', '/dev/null'],
677	679	stdin=subprocess.PIPE, stderr=subprocess.PIPE,
678		- stdout=subprocess.PIPE)
	680	+ stdout=subprocess.PIPE, env=custom_env)
679	681	except OSError:
680	682	error('''No acceptable C compiler found!
681	683

0 commit comments

Comments

0 (0)