assert: make `assert.fail` less affected by prototype tampering · nodejs/node@c6a814c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 636
• Pull requests 761
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c6a814c

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

juanarbol

committed

assert: make assert.fail less affected by prototype tampering

PR-URL: #42918 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent f120658 commit c6a814c
Copy full SHA for c6a814c

2 files changed

+6-1Lines changed: 6 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/assert
  • assertion_error.js
• test/parallel
  • test-assert-fail.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/assert/assertion_error.js‎

Copy file name to clipboardExpand all lines: lib/internal/assert/assertion_error.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -441,6 +441,7 @@ class AssertionError extends Error {
441	441
442	442	this.generatedMessage = !message;
443	443	ObjectDefineProperty(this, 'name', {
	444	+ __proto__: null,
444	445	value: 'AssertionError [ERR_ASSERTION]',
445	446	enumerable: false,
446	447	writable: true,

Collapse file

‎test/parallel/test-assert-fail.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-assert-fail.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,6 +1,6 @@
1	1	'use strict';
2	2
3		- require('../common');
	3	+ const common = require('../common');
4	4	const assert = require('assert');
5	5
6	6	// No args
@@ -38,3 +38,7 @@ assert.throws(() => {
38	38	name: 'TypeError',
39	39	message: 'custom message'
40	40	});
	41	+
	42	+ Object.prototype.get = common.mustNotCall();
	43	+ assert.throws(() => assert.fail(''), { code: 'ERR_ASSERTION' });
	44	+ delete Object.prototype.get;

0 commit comments

Comments

0 (0)