Commit c6b4e96
committed
test: adapt test-worker-debug for V8 10.0
V8 is removing callFrame.url.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3345001
PR-URL: #42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent 0854fce commit c6b4e96
1 file changed
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,7 +6,6 @@ common.skipIfInspectorDisabled(); | |||
| 6 | 6 | const assert = require('assert'); | |
| 7 | 7 | const EventEmitter = require('events'); | |
| 8 | 8 | const { Session } = require('inspector'); | |
| 9 | - const { pathToFileURL } = require('url'); | ||
| 10 | 9 | const { | |
| 11 | 10 | Worker, isMainThread, parentPort, workerData | |
| 12 | 11 | } = require('worker_threads'); | |
@@ -106,7 +105,6 @@ class WorkerSession extends EventEmitter { | |||
| 106 | 105 | this.post(command); | |
| 107 | 106 | const notification = await notificationPromise; | |
| 108 | 107 | const callFrame = notification.params.callFrames[0]; | |
| 109 | - assert.strictEqual(callFrame.url, pathToFileURL(script).toString()); | ||
| 110 | 108 | assert.strictEqual(callFrame.location.lineNumber, line); | |
| 111 | 109 | } | |
| 112 | 110 | ||
@@ -153,7 +151,7 @@ async function testBasicWorkerDebug(session, post) { | |||
| 153 | 151 | await workerSession.waitForBreakAfterCommand( | |
| 154 | 152 | 'Runtime.runIfWaitingForDebugger', __filename, 1); | |
| 155 | 153 | await workerSession.waitForBreakAfterCommand( | |
| 156 | - 'Debugger.resume', __filename, 26); // V8 line number is zero-based | ||
| 154 | + 'Debugger.resume', __filename, 25); // V8 line number is zero-based | ||
| 157 | 155 | const msg = await consolePromise; | |
| 158 | 156 | assert.strictEqual(msg, workerMessage); | |
| 159 | 157 | workerSession.post('Debugger.resume'); | |
0 commit comments