Commit c757fa5
crypto: add missing null check
Add null check before using result of
ERR_reason_error_string. Coverity reported as an issue
and we seem to do a null check in other places we call
the function.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #40598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>1 parent 93ea166 commit c757fa5
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1037,6 +1037,8 @@ void SecureContext::LoadPKCS12(const FunctionCallbackInfo<Value>& args) { | |||
| 1037 | 1037 | // TODO(@jasnell): Should this use ThrowCryptoError? | |
| 1038 | 1038 | unsigned long err = ERR_get_error(); // NOLINT(runtime/int) | |
| 1039 | 1039 | const char* str = ERR_reason_error_string(err); | |
| 1040 | + str = str != nullptr ? str : "Unknown error"; | ||
| 1041 | + | ||
| 1040 | 1042 | return env->ThrowError(str); | |
| 1041 | 1043 | } | |
| 1042 | 1044 | } | |
0 commit comments