Commit c776c92
build: re-enable V8 concurrent marking
It was unintentionally disabled during a V8 update.
Fixes: #41012
PR-URL: #41013
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent dc0405e commit c776c92
2 files changed
Lines changed: 19 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -147,6 +147,16 @@ | |||
| 147 | 147 | # Sets -dV8_TRACE_FEEDBACK_UPDATES. | |
| 148 | 148 | 'v8_enable_trace_feedback_updates%': 0, | |
| 149 | 149 | ||
| 150 | + # Sets -dV8_ATOMIC_OBJECT_FIELD_WRITES and turns all field write operations | ||
| 151 | + # into relaxed atomic operations. | ||
| 152 | + 'v8_enable_atomic_object_field_writes%': 1, | ||
| 153 | + | ||
| 154 | + # Sets -dV8_ATOMIC_MARKING_STATE | ||
| 155 | + 'v8_enable_atomic_marking_state%': 1, | ||
| 156 | + | ||
| 157 | + # Has no effect in Node.js. Here for completeness with V8's config. | ||
| 158 | + 'v8_enable_concurrent_marking%': 1, | ||
| 159 | + | ||
| 150 | 160 | # Enables various testing features. | |
| 151 | 161 | 'v8_enable_test_features%': 0, | |
| 152 | 162 | ||
@@ -343,6 +353,12 @@ | |||
| 343 | 353 | ['v8_enable_third_party_heap==1', { | |
| 344 | 354 | 'defines': ['V8_ENABLE_THIRD_PARTY_HEAP',], | |
| 345 | 355 | }], | |
| 356 | + ['v8_enable_atomic_object_field_writes==1', { | ||
| 357 | + 'defines': ['V8_ATOMIC_OBJECT_FIELD_WRITES',], | ||
| 358 | + }], | ||
| 359 | + ['v8_enable_atomic_marking_state==1', { | ||
| 360 | + 'defines': ['V8_ATOMIC_MARKING_STATE',], | ||
| 361 | + }], | ||
| 346 | 362 | ['v8_enable_lazy_source_positions==1', { | |
| 347 | 363 | 'defines': ['V8_ENABLE_LAZY_SOURCE_POSITIONS',], | |
| 348 | 364 | }], | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1713,12 +1713,9 @@ | |||
| 1713 | 1713 | 'is_ubsan_vptr=0', | |
| 1714 | 1714 | 'target_cpu=<(target_arch)', | |
| 1715 | 1715 | 'v8_current_cpu=<(v8_current_cpu)', | |
| 1716 | - # Not available in gyp. | ||
| 1717 | - 'v8_enable_atomic_marking_state=0', | ||
| 1718 | - # Not available in gyp. | ||
| 1719 | - 'v8_enable_atomic_object_field_writes=0', | ||
| 1720 | - # Not available in gyp. | ||
| 1721 | - 'v8_enable_concurrent_marking=0', | ||
| 1716 | + 'v8_enable_atomic_marking_state=<(v8_enable_atomic_marking_state)', | ||
| 1717 | + 'v8_enable_atomic_object_field_writes=<(v8_enable_atomic_object_field_writes)', | ||
| 1718 | + 'v8_enable_concurrent_marking=<(v8_enable_concurrent_marking)', | ||
| 1722 | 1719 | 'v8_enable_i18n_support=<(v8_enable_i18n_support)', | |
| 1723 | 1720 | 'v8_enable_verify_predictable=<(v8_enable_verify_predictable)', | |
| 1724 | 1721 | 'v8_enable_verify_csa=<(v8_enable_verify_csa)', | |
0 commit comments