test: ensure NODE_EXTRA_CA_CERTS not set before tests · nodejs/node@c782c3d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c782c3d

Browse filesBrowse the repository at this point in the historyBrowse files

KrayzeeKev

authored and

danielleadams

committed

test: ensure NODE_EXTRA_CA_CERTS not set before tests

The 'test-tls-env-extra-ca-file-load.js' test assumes that NODE_EXTRA_CA_CERTS is not set. If the build environment happens to have it set, this test will fail. This change deletes that env var before running the test. PR-URL: #43858 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent c9ecd6d commit c782c3d
Copy full SHA for c782c3d

1 file changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-tls-env-extra-ca-file-load.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-tls-env-extra-ca-file-load.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-env-extra-ca-file-load.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -20,6 +20,8 @@ if (process.argv[2] !== 'child') {
20	20	const NODE_EXTRA_CA_CERTS = fixtures.path('keys', 'ca1-cert.pem');
21	21	const extendsEnv = (obj) => ({ ...process.env, ...obj });
22	22
	23	+ // Remove any pre-existing extra CA certs.
	24	+ delete process.env.NODE_EXTRA_CA_CERTS;
23	25	[
24	26	extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'yes', NODE_EXTRA_CA_CERTS }),
25	27	extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'no' }),

0 commit comments

Comments

0 (0)