Commit c7a4525
buffer: improve ERR_BUFFER_OUT_OF_BOUNDS default
This commit changes the default message used by
ERR_BUFFER_OUT_OF_BOUNDS. Previously, the default
message implied that the problematic was always a
write, which is not accurate.
PR-URL: #29098
Fixes: #29097
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 66249bb commit c7a4525
7 files changed
Lines changed: 7 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -705,7 +705,7 @@ E('ERR_BUFFER_OUT_OF_BOUNDS', | |||
| 705 | 705 | if (name) { | |
| 706 | 706 | return `"${name}" is outside of buffer bounds`; | |
| 707 | 707 | } | |
| 708 | - return 'Attempt to write outside buffer bounds'; | ||
| 708 | + return 'Attempt to access memory outside buffer bounds'; | ||
| 709 | 709 | }, RangeError); | |
| 710 | 710 | E('ERR_BUFFER_TOO_LARGE', | |
| 711 | 711 | `Cannot create a Buffer larger than 0x${kMaxLength.toString(16)} bytes`, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -362,7 +362,7 @@ common.expectsError(() => { | |||
| 362 | 362 | }, { | |
| 363 | 363 | code: 'ERR_BUFFER_OUT_OF_BOUNDS', | |
| 364 | 364 | type: RangeError, | |
| 365 | - message: 'Attempt to write outside buffer bounds' | ||
| 365 | + message: 'Attempt to access memory outside buffer bounds' | ||
| 366 | 366 | }); | |
| 367 | 367 | ||
| 368 | 368 | assert.deepStrictEqual( | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -60,7 +60,7 @@ const OOR_ERROR = | |||
| 60 | 60 | const OOB_ERROR = | |
| 61 | 61 | { | |
| 62 | 62 | name: 'RangeError', | |
| 63 | - message: 'Attempt to write outside buffer bounds' | ||
| 63 | + message: 'Attempt to access memory outside buffer bounds' | ||
| 64 | 64 | }; | |
| 65 | 65 | ||
| 66 | 66 | // Attempt to overflow buffers, similar to previous bug in array buffers | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -127,7 +127,7 @@ assert.strictEqual(buffer.readDoubleLE(0), -Infinity); | |||
| 127 | 127 | { | |
| 128 | 128 | code: 'ERR_BUFFER_OUT_OF_BOUNDS', | |
| 129 | 129 | name: 'RangeError', | |
| 130 | - message: 'Attempt to write outside buffer bounds' | ||
| 130 | + message: 'Attempt to access memory outside buffer bounds' | ||
| 131 | 131 | }); | |
| 132 | 132 | ||
| 133 | 133 | [NaN, 1.01].forEach((offset) => { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -90,7 +90,7 @@ assert.strictEqual(buffer.readFloatLE(0), -Infinity); | |||
| 90 | 90 | { | |
| 91 | 91 | code: 'ERR_BUFFER_OUT_OF_BOUNDS', | |
| 92 | 92 | name: 'RangeError', | |
| 93 | - message: 'Attempt to write outside buffer bounds' | ||
| 93 | + message: 'Attempt to access memory outside buffer bounds' | ||
| 94 | 94 | }); | |
| 95 | 95 | ||
| 96 | 96 | [NaN, 1.01].forEach((offset) => { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -99,7 +99,7 @@ assert.ok(Number.isNaN(buffer.readDoubleLE(8))); | |||
| 99 | 99 | { | |
| 100 | 100 | code: 'ERR_BUFFER_OUT_OF_BOUNDS', | |
| 101 | 101 | name: 'RangeError', | |
| 102 | - message: 'Attempt to write outside buffer bounds' | ||
| 102 | + message: 'Attempt to access memory outside buffer bounds' | ||
| 103 | 103 | }); | |
| 104 | 104 | ||
| 105 | 105 | ['', '0', null, {}, [], () => {}, true, false].forEach((off) => { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -81,7 +81,7 @@ assert.ok(Number.isNaN(buffer.readFloatLE(4))); | |||
| 81 | 81 | { | |
| 82 | 82 | code: 'ERR_BUFFER_OUT_OF_BOUNDS', | |
| 83 | 83 | name: 'RangeError', | |
| 84 | - message: 'Attempt to write outside buffer bounds' | ||
| 84 | + message: 'Attempt to access memory outside buffer bounds' | ||
| 85 | 85 | }); | |
| 86 | 86 | ||
| 87 | 87 | ['', '0', null, {}, [], () => {}, true, false].forEach((off) => { | |
0 commit comments