stream: handle undefined chunks correctly in decode stream · nodejs/node@c7ed2ff · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c7ed2ff

Browse filesBrowse the repository at this point in the historyBrowse files

Nahee-Park

authored and

targos

committed

stream: handle undefined chunks correctly in decode stream

Align TextDecoderStream behavior with WPT requirements by treating undefined chunks as errors. This change ensures that TextDecoderStream properly handles unexpected chunk types and throws an error when receiving undefined input. This update addresses the failing WPT for decode stream error handling. PR-URL: #55153 Reviewed-By: Mattias Buelens <mattias@buelens.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

1 parent aaea394 commit c7ed2ff
Copy full SHA for c7ed2ff

2 files changed

+4-7Lines changed: 4 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/webstreams
  • encoding.js
• test/wpt/status
  • encoding.json

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/webstreams/encoding.js‎

Copy file name to clipboardExpand all lines: lib/internal/webstreams/encoding.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -20,6 +20,7 @@ const { customInspect } = require('internal/webstreams/util');
20	20
21	21	const {
22	22	codes: {
	23	+ ERR_INVALID_ARG_TYPE,
23	24	ERR_INVALID_THIS,
24	25	},
25	26	} = require('internal/errors');
@@ -133,6 +134,9 @@ class TextDecoderStream {
133	134	this.#handle = new TextDecoder(encoding, options);
134	135	this.#transform = new TransformStream({
135	136	transform: (chunk, controller) => {
	137	+ if (chunk === undefined) {
	138	+ throw new ERR_INVALID_ARG_TYPE('chunk', 'string', chunk);
	139	+ }
136	140	const value = this.#handle.decode(chunk, { stream: true });
137	141	if (value)
138	142	controller.enqueue(value);

Collapse file

‎test/wpt/status/encoding.json‎

Copy file name to clipboardExpand all lines: test/wpt/status/encoding.json

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -66,13 +66,6 @@
66	66	"streams/decode-utf8.any.js": {
67	67	"requires": ["small-icu"]
68	68	},
69		- "streams/decode-bad-chunks.any.js": {
70		- "fail": {
71		- "expected": [
72		- "chunk of type undefined should error the stream"
73		- ]
74		- }
75		- },
76	69	"streams/decode-non-utf8.any.js": {
77	70	"requires": ["full-icu"]
78	71	},

0 commit comments

Comments

0 (0)