Commit c8e1782
deps: V8: cherry-pick c1a54d5ffcd1
Original commit message:
Skip regress-1320641 when the system does not have enough memory
Change-Id: I23a5232f6437c4bc77390796ee2986f1600cb1bf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4689686
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#88973}
Refs: v8/v8@c1a54d5
PR-URL: #48830
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>1 parent 4515a28 commit c8e1782
2 files changed
Lines changed: 18 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.10', | ||
| 39 | + 'v8_embedder_string': '-node.12', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,9 +8,21 @@ function foo(){ | |||
| 8 | 8 | const xs = new Uint16Array(3775336418); | |
| 9 | 9 | return xs[-981886074]; | |
| 10 | 10 | } | |
| 11 | - %PrepareFunctionForOptimization(foo); | ||
| 12 | - foo(); | ||
| 13 | 11 | ||
| 14 | - assertEquals(undefined, foo()); | ||
| 15 | - %OptimizeFunctionOnNextCall(foo); | ||
| 16 | - assertEquals(undefined, foo()); | ||
| 12 | + var skip = false; | ||
| 13 | + try { | ||
| 14 | + new Uint16Array(3775336418); | ||
| 15 | + } catch (e) { | ||
| 16 | + if (e.message.test(/Array buffer allocation failed/)) { | ||
| 17 | + skip = true; // We don't have enough memory, just skip the test. | ||
| 18 | + } | ||
| 19 | + } | ||
| 20 | + | ||
| 21 | + if (!skip) { | ||
| 22 | + %PrepareFunctionForOptimization(foo); | ||
| 23 | + foo(); | ||
| 24 | + | ||
| 25 | + assertEquals(undefined, foo()); | ||
| 26 | + %OptimizeFunctionOnNextCall(foo); | ||
| 27 | + assertEquals(undefined, foo()); | ||
| 28 | + } | ||
0 commit comments