test: update test-http-upgrade-client to use countdown · nodejs/node@c9a4f4f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 589
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c9a4f4f

Browse filesBrowse the repository at this point in the historyBrowse files

mithunsasidharan

authored and

MylesBorins

committed

test: update test-http-upgrade-client to use countdown

PR-URL: #17339 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

1 parent 91d5416 commit c9a4f4f
Copy full SHA for c9a4f4f

1 file changed

+4-3Lines changed: 4 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-upgrade-client.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-upgrade-client.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-upgrade-client.js

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -29,6 +29,7 @@ const assert = require('assert');
29	29
30	30	const http = require('http');
31	31	const net = require('net');
	32	+ const Countdown = require('../common/countdown');
32	33
33	34	// Create a TCP server
34	35	const srv = net.createServer(function(c) {
@@ -60,7 +61,8 @@ srv.listen(0, '127.0.0.1', common.mustCall(function() {
60	61	['Origin', 'http://www.websocket.org']
61	62	]
62	63	];
63		- let left = headers.length;
	64	+ const countdown = new Countdown(headers.length, () => srv.close());
	65	+
64	66	headers.forEach(function(h) {
65	67	const req = http.get({
66	68	port: port,
@@ -87,8 +89,7 @@ srv.listen(0, '127.0.0.1', common.mustCall(function() {
87	89	assert.deepStrictEqual(expectedHeaders, res.headers);
88	90
89	91	socket.end();
90		- if (--left === 0)
91		- srv.close();
	92	+ countdown.dec();
92	93	}));
93	94	req.on('close', common.mustCall(function() {
94	95	assert.strictEqual(sawUpgrade, true);

0 commit comments

Comments

0 (0)