Commit ca4a0e3
test: fix parsing test flags
This removes replacing `_` with `-` in the flags defined.
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #48012
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 2ba08ac commit ca4a0e3
1 file changed
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -81,7 +81,6 @@ function parseTestFlags(filename = process.argv[1]) { | |||
| 81 | 81 | } | |
| 82 | 82 | return source | |
| 83 | 83 | .substring(flagStart, flagEnd) | |
| 84 | - .replace(/_/g, '-') | ||
| 85 | 84 | .split(/\s+/) | |
| 86 | 85 | .filter(Boolean); | |
| 87 | 86 | } | |
@@ -97,9 +96,8 @@ if (process.argv.length === 2 && | |||
| 97 | 96 | require('cluster').isPrimary && | |
| 98 | 97 | fs.existsSync(process.argv[1])) { | |
| 99 | 98 | const flags = parseTestFlags(); | |
| 100 | - const args = process.execArgv.map((arg) => arg.replace(/_/g, '-')); | ||
| 101 | 99 | for (const flag of flags) { | |
| 102 | - if (!args.includes(flag) && | ||
| 100 | + if (!process.execArgv.includes(flag) && | ||
| 103 | 101 | // If the binary is build without `intl` the inspect option is | |
| 104 | 102 | // invalid. The test itself should handle this case. | |
| 105 | 103 | (process.features.inspector || !flag.startsWith('--inspect'))) { | |
0 commit comments