events: update MaxListenersExceededWarning message log · nodejs/node@ca5607b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ca5607b

Browse filesBrowse the repository at this point in the historyBrowse files

sinkhaha

authored and

targos

committed

events: update MaxListenersExceededWarning message log

PR-URL: #51921 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent fca38b2 commit ca5607b
Copy full SHA for ca5607b

6 files changed

+9-6Lines changed: 9 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • events.js
  • internal
    • event_target.js
• test/parallel
  • test-event-emitter-max-listeners-warning-for-null.js
  • test-event-emitter-max-listeners-warning-for-symbol.js
  • test-event-emitter-max-listeners-warning.js
  • test-eventtarget-memoryleakwarning.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/events.js‎

Copy file name to clipboardExpand all lines: lib/events.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -593,7 +593,7 @@ function _addListener(target, type, listener, prepend) {
593	593	// No error code for this since it is a Warning
594	594	const w = genericNodeError(
595	595	`Possible EventEmitter memory leak detected. ${existing.length} ${String(type)} listeners ` +
596		- `added to ${inspect(target, { depth: -1 })}. Use emitter.setMaxListeners() to increase limit`,
	596	+ `added to ${inspect(target, { depth: -1 })}. MaxListeners is ${m}. Use emitter.setMaxListeners() to increase limit`,
597	597	{ name: 'MaxListenersExceededWarning', emitter: target, type: type, count: existing.length });
598	598	process.emitWarning(w);
599	599	}

Collapse file

‎lib/internal/event_target.js‎

Copy file name to clipboardExpand all lines: lib/internal/event_target.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -561,7 +561,7 @@ class EventTarget {
561	561	// eslint-disable-next-line no-restricted-syntax
562	562	const w = new Error('Possible EventTarget memory leak detected. ' +
563	563	`${size} ${type} listeners ` +
564		- `added to ${inspect(this, { depth: -1 })}. Use ` +
	564	+ `added to ${inspect(this, { depth: -1 })}. MaxListeners is ${this[kMaxEventTargetListeners]}. Use ` +
565	565	'events.setMaxListeners() to increase limit');
566	566	w.name = 'MaxListenersExceededWarning';
567	567	w.target = this;

Collapse file

‎test/parallel/test-event-emitter-max-listeners-warning-for-null.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-event-emitter-max-listeners-warning-for-null.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -16,7 +16,7 @@ process.on('warning', common.mustCall((warning) => {
16	16	assert.strictEqual(warning.count, 2);
17	17	assert.strictEqual(warning.type, null);
18	18	assert.ok(warning.message.includes(
19		- '2 null listeners added to [EventEmitter].'));
	19	+ '2 null listeners added to [EventEmitter]. MaxListeners is 1.'));
20	20	}));
21	21
22	22	e.on(null, () => {});

Collapse file

‎test/parallel/test-event-emitter-max-listeners-warning-for-symbol.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-event-emitter-max-listeners-warning-for-symbol.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -18,7 +18,7 @@ process.on('warning', common.mustCall((warning) => {
18	18	assert.strictEqual(warning.count, 2);
19	19	assert.strictEqual(warning.type, symbol);
20	20	assert.ok(warning.message.includes(
21		- '2 Symbol(symbol) listeners added to [EventEmitter].'));
	21	+ '2 Symbol(symbol) listeners added to [EventEmitter]. MaxListeners is 1.'));
22	22	}));
23	23
24	24	e.on(symbol, () => {});

Collapse file

‎test/parallel/test-event-emitter-max-listeners-warning.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-event-emitter-max-listeners-warning.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -23,7 +23,7 @@ process.on('warning', common.mustCall((warning) => {
23	23	assert.strictEqual(warning.count, 2);
24	24	assert.strictEqual(warning.type, 'event-type');
25	25	assert.ok(warning.message.includes(
26		- '2 event-type listeners added to [FakeInput].'));
	26	+ '2 event-type listeners added to [FakeInput]. MaxListeners is 1.'));
27	27	}));
28	28
29	29	e.on('event-type', () => {});

Collapse file

‎test/parallel/test-eventtarget-memoryleakwarning.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-eventtarget-memoryleakwarning.js

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -12,18 +12,21 @@ const { setTimeout } = require('timers/promises');
12	12	common.expectWarning({
13	13	MaxListenersExceededWarning: [
14	14	['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
15		- 'EventTarget. Use events.setMaxListeners() ' +
	15	+ 'EventTarget. MaxListeners is 2. Use events.setMaxListeners() ' +
16	16	'to increase limit'],
17	17	['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
18	18	'[MessagePort [EventTarget]]. ' +
	19	+ 'MaxListeners is 2. ' +
19	20	'Use events.setMaxListeners() to increase ' +
20	21	'limit'],
21	22	['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
22	23	'[MessagePort [EventTarget]]. ' +
	24	+ 'MaxListeners is 2. ' +
23	25	'Use events.setMaxListeners() to increase ' +
24	26	'limit'],
25	27	['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
26	28	'[AbortSignal]. ' +
	29	+ 'MaxListeners is 2. ' +
27	30	'Use events.setMaxListeners() to increase ' +
28	31	'limit'],
29	32	],

0 commit comments

Comments

0 (0)