Commit ca947ac
doc: remove outdated step in onboarding exercise
The GitHub bot will leave a comment asking people to thumbs-up a fast
track request so there is no need to manually leave such a comment.
PR-URL: #39410
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 86e1260 commit ca947ac
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -204,12 +204,12 @@ needs to be pointed out separately during the onboarding. | |||
| 204 | 204 | so that when the commit lands, the nomination issue url will be | |
| 205 | 205 | automatically closed. | |
| 206 | 206 | * Label your pull request with the `doc`, `notable-change`, and `fast-track` | |
| 207 | - labels. | ||
| 207 | + labels. The `fast-track` label should cause the Node.js GitHub bot to post a | ||
| 208 | + comment in the pull request asking collaborators to approve the pull request | ||
| 209 | + by leaving a 👍 reaction on the comment. | ||
| 208 | 210 | * Run CI on the pull request. Use the `node-test-pull-request` CI task. | |
| 209 | 211 | * After two Collaborator approvals for the change and two Collaborator approvals | |
| 210 | - for fast-tracking, land the pull request. | ||
| 211 | - * Leave a comment in the pull request: | ||
| 212 | - `Please 👍 this comment to approve fast-tracking`. | ||
| 212 | + for fast-tracking, land the PR. | ||
| 213 | 213 | * If there are not enough approvals within a reasonable time, consider the | |
| 214 | 214 | single approval of the onboarding TSC member sufficient, and land the pull | |
| 215 | 215 | request. | |
0 commit comments