test: fix inconsistency write size in `test-fs-readfile-tostring-fail` · nodejs/node@cab7737 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit cab7737

Browse filesBrowse the repository at this point in the historyBrowse files

Jungku Lee

authored and

richardlau

committed

test: fix inconsistency write size in test-fs-readfile-tostring-fail

PR-URL: #51141 Refs: #51133 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

1 parent 4ffdd37 commit cab7737
Copy full SHA for cab7737

1 file changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/pummel
  • test-fs-readfile-tostring-fail.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/pummel/test-fs-readfile-tostring-fail.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-fs-readfile-tostring-fail.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -9,13 +9,15 @@ const assert = require('assert');
9	9	const fs = require('fs');
10	10	const cp = require('child_process');
11	11	const kStringMaxLength = require('buffer').constants.MAX_STRING_LENGTH;
	12	+ const size = Math.floor(kStringMaxLength / 200);
	13	+
12	14	if (common.isAIX && (Number(cp.execSync('ulimit -f')) * 512) < kStringMaxLength)
13	15	common.skip('intensive toString tests due to file size confinements');
14	16
15	17	const tmpdir = require('../common/tmpdir');
16	18	tmpdir.refresh();
17	19
18		- if (!tmpdir.hasEnoughSpace(kStringMaxLength)) {
	20	+ if (!tmpdir.hasEnoughSpace(kStringMaxLength + size)) {
19	21	common.skip(`Not enough space in ${tmpdir.path}`);
20	22	}
21	23
@@ -26,7 +28,6 @@ const stream = fs.createWriteStream(file, {
26	28
27	29	stream.on('error', (err) => { throw err; });
28	30
29		- const size = kStringMaxLength / 200;
30	31	const a = Buffer.alloc(size, 'a');
31	32	let expectedSize = 0;
32	33

0 commit comments

Comments

0 (0)