Commit cb15017
test: fix flaky parallel/test-fs-write-file-typedarrays
Using the same filename for different async tests could lead
to race conditions.
Example failure: https://travis-ci.com/nodejs/node/jobs/143351655
Refs: #22150
PR-URL: #22659
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 71502f2 commit cb15017
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -32,10 +32,11 @@ for (const expectView of common.getArrayBufferViews(inputBuffer)) { | |||
| 32 | 32 | ||
| 33 | 33 | for (const expectView of common.getArrayBufferViews(inputBuffer)) { | |
| 34 | 34 | console.log('Async test for ', expectView[Symbol.toStringTag]); | |
| 35 | - fs.writeFile(filename, expectView, common.mustCall((e) => { | ||
| 35 | + const file = `${filename}-${expectView[Symbol.toStringTag]}`; | ||
| 36 | + fs.writeFile(file, expectView, common.mustCall((e) => { | ||
| 36 | 37 | assert.ifError(e); | |
| 37 | 38 | ||
| 38 | - fs.readFile(filename, 'utf8', common.mustCall((err, data) => { | ||
| 39 | + fs.readFile(file, 'utf8', common.mustCall((err, data) => { | ||
| 39 | 40 | assert.ifError(err); | |
| 40 | 41 | assert.strictEqual(data, inputBuffer.toString('utf8')); | |
| 41 | 42 | })); | |
0 commit comments