Commit cb24fc7
src: remove unused checkMessagePort internal binding
PR-URL: #58267
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent 4db5d0b commit cb24fc7
3 files changed
Lines changed: 0 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1141,13 +1141,6 @@ void MessagePort::Stop(const FunctionCallbackInfo<Value>& args) { | |||
| 1141 | 1141 | port->Stop(); | |
| 1142 | 1142 | } | |
| 1143 | 1143 | ||
| 1144 | - void MessagePort::CheckType(const FunctionCallbackInfo<Value>& args) { | ||
| 1145 | - Environment* env = Environment::GetCurrent(args); | ||
| 1146 | - args.GetReturnValue().Set( | ||
| 1147 | - GetMessagePortConstructorTemplate(env->isolate_data()) | ||
| 1148 | - ->HasInstance(args[0])); | ||
| 1149 | - } | ||
| 1150 | - | ||
| 1151 | 1144 | void MessagePort::Drain(const FunctionCallbackInfo<Value>& args) { | |
| 1152 | 1145 | MessagePort* port; | |
| 1153 | 1146 | ASSIGN_OR_RETURN_UNWRAP(&port, args[0].As<Object>()); | |
@@ -1731,7 +1724,6 @@ static void CreatePerIsolateProperties(IsolateData* isolate_data, | |||
| 1731 | 1724 | // These are not methods on the MessagePort prototype, because | |
| 1732 | 1725 | // the browser equivalents do not provide them. | |
| 1733 | 1726 | SetMethod(isolate, target, "stopMessagePort", MessagePort::Stop); | |
| 1734 | - SetMethod(isolate, target, "checkMessagePort", MessagePort::CheckType); | ||
| 1735 | 1727 | SetMethod(isolate, target, "drainMessagePort", MessagePort::Drain); | |
| 1736 | 1728 | SetMethod( | |
| 1737 | 1729 | isolate, target, "receiveMessageOnPort", MessagePort::ReceiveMessage); | |
@@ -1767,7 +1759,6 @@ static void RegisterExternalReferences(ExternalReferenceRegistry* registry) { | |||
| 1767 | 1759 | registry->Register(MessagePort::PostMessage); | |
| 1768 | 1760 | registry->Register(MessagePort::Start); | |
| 1769 | 1761 | registry->Register(MessagePort::Stop); | |
| 1770 | - registry->Register(MessagePort::CheckType); | ||
| 1771 | 1762 | registry->Register(MessagePort::Drain); | |
| 1772 | 1763 | registry->Register(MessagePort::ReceiveMessage); | |
| 1773 | 1764 | registry->Register(MessagePort::MoveToContext); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -261,7 +261,6 @@ class MessagePort : public HandleWrap { | |||
| 261 | 261 | static void PostMessage(const v8::FunctionCallbackInfo<v8::Value>& args); | |
| 262 | 262 | static void Start(const v8::FunctionCallbackInfo<v8::Value>& args); | |
| 263 | 263 | static void Stop(const v8::FunctionCallbackInfo<v8::Value>& args); | |
| 264 | - static void CheckType(const v8::FunctionCallbackInfo<v8::Value>& args); | ||
| 265 | 264 | static void Drain(const v8::FunctionCallbackInfo<v8::Value>& args); | |
| 266 | 265 | static void ReceiveMessage(const v8::FunctionCallbackInfo<v8::Value>& args); | |
| 267 | 266 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -23,7 +23,6 @@ export interface MessagingBinding { | |||
| 23 | 23 | MessagePort: typeof InternalMessagingBinding.MessagePort; | |
| 24 | 24 | JSTransferable: typeof InternalMessagingBinding.JSTransferable; | |
| 25 | 25 | stopMessagePort(port: typeof InternalMessagingBinding.MessagePort): void; | |
| 26 | - checkMessagePort(port: unknown): boolean; | ||
| 27 | 26 | drainMessagePort(port: typeof InternalMessagingBinding.MessagePort): void; | |
| 28 | 27 | receiveMessageOnPort(port: typeof InternalMessagingBinding.MessagePort): any; | |
| 29 | 28 | moveMessagePortToContext(port: typeof InternalMessagingBinding.MessagePort, context: any): typeof InternalMessagingBinding.MessagePort; | |
0 commit comments