fs: glob is stable, so should not emit experimental warnings · nodejs/node@cb39e4c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit cb39e4c

Browse filesBrowse the repository at this point in the historyBrowse files

theoludwig

authored and

aduh95

committed

fs: glob is stable, so should not emit experimental warnings

PR-URL: #58236 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent a71b9fc commit cb39e4c
Copy full SHA for cb39e4c

3 files changed

-7Lines changed: 0 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • fs.js
  • internal/fs
    • promises.js
  • path.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/fs.js‎

Copy file name to clipboardExpand all lines: lib/fs.js

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -86,7 +86,6 @@ const {
86	86	const { toPathIfFileURL } = require('internal/url');
87	87	const {
88	88	customPromisifyArgs: kCustomPromisifyArgsSymbol,
89		- emitExperimentalWarning,
90	89	getLazy,
91	90	kEmptyObject,
92	91	promisify: {
@@ -3186,7 +3185,6 @@ function createWriteStream(path, options) {
3186	3185	const lazyGlob = getLazy(() => require('internal/fs/glob').Glob);
3187	3186
3188	3187	function glob(pattern, options, callback) {
3189		- emitExperimentalWarning('glob');
3190	3188	if (typeof options === 'function') {
3191	3189	callback = options;
3192	3190	options = undefined;
@@ -3209,7 +3207,6 @@ function glob(pattern, options, callback) {
3209	3207	}
3210	3208
3211	3209	function globSync(pattern, options) {
3212		- emitExperimentalWarning('globSync');
3213	3210	const Glob = lazyGlob();
3214	3211	return new Glob(pattern, options).globSync();
3215	3212	}

Collapse file

‎lib/internal/fs/promises.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/promises.js

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -91,7 +91,6 @@ const pathModule = require('path');
91	91	const { isAbsolute } = pathModule;
92	92	const { toPathIfFileURL } = require('internal/url');
93	93	const {
94		- emitExperimentalWarning,
95	94	getLazy,
96	95	kEmptyObject,
97	96	lazyDOMException,
@@ -1260,7 +1259,6 @@ async function* _watch(filename, options = kEmptyObject) {
1260	1259
1261	1260	const lazyGlob = getLazy(() => require('internal/fs/glob').Glob);
1262	1261	async function* glob(pattern, options) {
1263		- emitExperimentalWarning('glob');
1264	1262	const Glob = lazyGlob();
1265	1263	yield* new Glob(pattern, options).glob();
1266	1264	}

Collapse file

‎lib/path.js‎

Copy file name to clipboardExpand all lines: lib/path.js

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -54,7 +54,6 @@ const {
54	54
55	55	const {
56	56	getLazy,
57		- emitExperimentalWarning,
58	57	isWindows,
59	58	isMacOS,
60	59	} = require('internal/util');
@@ -166,7 +165,6 @@ function _format(sep, pathObject) {
166	165	}
167	166
168	167	function glob(path, pattern, windows) {
169		- emitExperimentalWarning('glob');
170	168	validateString(path, 'path');
171	169	validateString(pattern, 'pattern');
172	170	return lazyMinimatch().minimatch(path, pattern, {

0 commit comments

Comments

0 (0)