Commit cb732ae
doc: enable eslint prefer-template rule
Backport-PR-URL: #19244
PR-URL: #18831
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent b04dd7b commit cb732ae
3 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -12,6 +12,7 @@ rules: | |||
| 12 | 12 | no-var: error | |
| 13 | 13 | prefer-const: error | |
| 14 | 14 | prefer-rest-params: error | |
| 15 | + prefer-template: error | ||
| 15 | 16 | ||
| 16 | 17 | # Stylistic Issues | |
| 17 | 18 | no-multiple-empty-lines: [error, {max: 1, maxEOF: 0, maxBOF: 0}] | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -114,7 +114,7 @@ given module specifier and parent file URL: | |||
| 114 | 114 | ||
| 115 | 115 | ```js | |
| 116 | 116 | const baseURL = new URL('file://'); | |
| 117 | - baseURL.pathname = process.cwd() + '/'; | ||
| 117 | + baseURL.pathname = `${process.cwd()}/`; | ||
| 118 | 118 | ||
| 119 | 119 | export async function resolve(specifier, | |
| 120 | 120 | parentModuleURL = baseURL, | |
@@ -158,7 +158,7 @@ const builtins = Module.builtinModules; | |||
| 158 | 158 | const JS_EXTENSIONS = new Set(['.js', '.mjs']); | |
| 159 | 159 | ||
| 160 | 160 | const baseURL = new URL('file://'); | |
| 161 | - baseURL.pathname = process.cwd() + '/'; | ||
| 161 | + baseURL.pathname = `${process.cwd()}/`; | ||
| 162 | 162 | ||
| 163 | 163 | export function resolve(specifier, parentModuleURL = baseURL, defaultResolve) { | |
| 164 | 164 | if (builtins.includes(specifier)) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1801,7 +1801,7 @@ class Counter extends Readable { | |||
| 1801 | 1801 | if (i > this._max) | |
| 1802 | 1802 | this.push(null); | |
| 1803 | 1803 | else { | |
| 1804 | - const str = '' + i; | ||
| 1804 | + const str = String(i); | ||
| 1805 | 1805 | const buf = Buffer.from(str, 'ascii'); | |
| 1806 | 1806 | this.push(buf); | |
| 1807 | 1807 | } | |
0 commit comments