Commit cb7f73c
tools: revise line in configure.py for clarity
* Replace unused identifier with Python convention `_`.
* Remove unneeded parentheses.
* Remove line-wrapping.
I confirmed that this doesn't change the output by running `./configure
--shared-zlib` and confirming that it created the same `common.gypi`
with and without these changes. The code changed here doesn't run unless
there is a `--shared-*` flag.
PR-URL: #36551
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>1 parent 3170636 commit cb7f73c
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1347,8 +1347,7 @@ def configure_library(lib, output, pkgname=None): | |||
| 1347 | 1347 | output['variables']['node_' + shared_lib] = b(getattr(options, shared_lib)) | |
| 1348 | 1348 | ||
| 1349 | 1349 | if getattr(options, shared_lib): | |
| 1350 | - (pkg_libs, pkg_cflags, pkg_libpath, pkg_modversion) = ( | ||
| 1351 | - pkg_config(pkgname or lib)) | ||
| 1350 | + (pkg_libs, pkg_cflags, pkg_libpath, _) = pkg_config(pkgname or lib) | ||
| 1352 | 1351 | ||
| 1353 | 1352 | if options.__dict__[shared_lib + '_includes']: | |
| 1354 | 1353 | output['include_dirs'] += [options.__dict__[shared_lib + '_includes']] | |
0 commit comments