Commit cb89fbc
build: don't use -latomic on macOS
Fixes build when using open-source clang.
Builds using Apple clang from Xcode v7 and later were already working,
due to the fact that node's build system misidentifies their
llvm_version as "0.0" and thus the flag wasn't being added.
PR-URL: #30099
Fixes: #30093
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent b554208 commit cb89fbc
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -292,7 +292,7 @@ | |||
| 292 | 292 | '-Wl,-bnoerrmsg', | |
| 293 | 293 | ], | |
| 294 | 294 | }], | |
| 295 | - ['OS in ("linux", "mac") and llvm_version != "0.0"', { | ||
| 295 | + ['OS == "linux" and llvm_version != "0.0"', { | ||
| 296 | 296 | 'libraries': ['-latomic'], | |
| 297 | 297 | }], | |
| 298 | 298 | ], | |
0 commit comments