Commit cbb2f81
querystring: replace var with let/const
PR-URL: #30429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent c0d9a54 commit cbb2f81
1 file changed
Lines changed: 31 additions & 31 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -67,15 +67,15 @@ const unhexTable = [ | |||
| 67 | 67 | // A safe fast alternative to decodeURIComponent | |
| 68 | 68 | function unescapeBuffer(s, decodeSpaces) { | |
| 69 | 69 | const out = Buffer.allocUnsafe(s.length); | |
| 70 | - var index = 0; | ||
| 71 | - var outIndex = 0; | ||
| 72 | - var currentChar; | ||
| 73 | - var nextChar; | ||
| 74 | - var hexHigh; | ||
| 75 | - var hexLow; | ||
| 70 | + let index = 0; | ||
| 71 | + let outIndex = 0; | ||
| 72 | + let currentChar; | ||
| 73 | + let nextChar; | ||
| 74 | + let hexHigh; | ||
| 75 | + let hexLow; | ||
| 76 | 76 | const maxLength = s.length - 2; | |
| 77 | 77 | // Flag to know if some hex chars have been decoded | |
| 78 | - var hasHex = false; | ||
| 78 | + let hasHex = false; | ||
| 79 | 79 | while (index < s.length) { | |
| 80 | 80 | currentChar = s.charCodeAt(index); | |
| 81 | 81 | if (currentChar === 43 /* '+' */ && decodeSpaces) { | |
@@ -161,27 +161,27 @@ function stringify(obj, sep, eq, options) { | |||
| 161 | 161 | sep = sep || '&'; | |
| 162 | 162 | eq = eq || '='; | |
| 163 | 163 | ||
| 164 | - var encode = QueryString.escape; | ||
| 164 | + let encode = QueryString.escape; | ||
| 165 | 165 | if (options && typeof options.encodeURIComponent === 'function') { | |
| 166 | 166 | encode = options.encodeURIComponent; | |
| 167 | 167 | } | |
| 168 | 168 | ||
| 169 | 169 | if (obj !== null && typeof obj === 'object') { | |
| 170 | - var keys = Object.keys(obj); | ||
| 171 | - var len = keys.length; | ||
| 172 | - var flast = len - 1; | ||
| 173 | - var fields = ''; | ||
| 174 | - for (var i = 0; i < len; ++i) { | ||
| 175 | - var k = keys[i]; | ||
| 176 | - var v = obj[k]; | ||
| 177 | - var ks = encode(stringifyPrimitive(k)); | ||
| 170 | + const keys = Object.keys(obj); | ||
| 171 | + const len = keys.length; | ||
| 172 | + const flast = len - 1; | ||
| 173 | + let fields = ''; | ||
| 174 | + for (let i = 0; i < len; ++i) { | ||
| 175 | + const k = keys[i]; | ||
| 176 | + const v = obj[k]; | ||
| 177 | + let ks = encode(stringifyPrimitive(k)); | ||
| 178 | 178 | ks += eq; | |
| 179 | 179 | ||
| 180 | 180 | if (Array.isArray(v)) { | |
| 181 | - var vlen = v.length; | ||
| 181 | + const vlen = v.length; | ||
| 182 | 182 | if (vlen === 0) continue; | |
| 183 | - var vlast = vlen - 1; | ||
| 184 | - for (var j = 0; j < vlen; ++j) { | ||
| 183 | + const vlast = vlen - 1; | ||
| 184 | + for (let j = 0; j < vlen; ++j) { | ||
| 185 | 185 | fields += ks; | |
| 186 | 186 | fields += encode(stringifyPrimitive(v[j])); | |
| 187 | 187 | if (j < vlast) | |
@@ -204,7 +204,7 @@ function charCodes(str) { | |||
| 204 | 204 | if (str.length === 0) return []; | |
| 205 | 205 | if (str.length === 1) return [str.charCodeAt(0)]; | |
| 206 | 206 | const ret = new Array(str.length); | |
| 207 | - for (var i = 0; i < str.length; ++i) | ||
| 207 | + for (let i = 0; i < str.length; ++i) | ||
| 208 | 208 | ret[i] = str.charCodeAt(i); | |
| 209 | 209 | return ret; | |
| 210 | 210 | } | |
@@ -244,7 +244,7 @@ function parse(qs, sep, eq, options) { | |||
| 244 | 244 | const sepLen = sepCodes.length; | |
| 245 | 245 | const eqLen = eqCodes.length; | |
| 246 | 246 | ||
| 247 | - var pairs = 1000; | ||
| 247 | + let pairs = 1000; | ||
| 248 | 248 | if (options && typeof options.maxKeys === 'number') { | |
| 249 | 249 | // -1 is used in place of a value like Infinity for meaning | |
| 250 | 250 | // "unlimited pairs" because of additional checks V8 (at least as of v5.4) | |
@@ -255,22 +255,22 @@ function parse(qs, sep, eq, options) { | |||
| 255 | 255 | pairs = (options.maxKeys > 0 ? options.maxKeys : -1); | |
| 256 | 256 | } | |
| 257 | 257 | ||
| 258 | - var decode = QueryString.unescape; | ||
| 258 | + let decode = QueryString.unescape; | ||
| 259 | 259 | if (options && typeof options.decodeURIComponent === 'function') { | |
| 260 | 260 | decode = options.decodeURIComponent; | |
| 261 | 261 | } | |
| 262 | 262 | const customDecode = (decode !== qsUnescape); | |
| 263 | 263 | ||
| 264 | - var lastPos = 0; | ||
| 265 | - var sepIdx = 0; | ||
| 266 | - var eqIdx = 0; | ||
| 267 | - var key = ''; | ||
| 268 | - var value = ''; | ||
| 269 | - var keyEncoded = customDecode; | ||
| 270 | - var valEncoded = customDecode; | ||
| 264 | + let lastPos = 0; | ||
| 265 | + let sepIdx = 0; | ||
| 266 | + let eqIdx = 0; | ||
| 267 | + let key = ''; | ||
| 268 | + let value = ''; | ||
| 269 | + let keyEncoded = customDecode; | ||
| 270 | + let valEncoded = customDecode; | ||
| 271 | 271 | const plusChar = (customDecode ? '%20' : ' '); | |
| 272 | - var encodeCheck = 0; | ||
| 273 | - for (var i = 0; i < qs.length; ++i) { | ||
| 272 | + let encodeCheck = 0; | ||
| 273 | + for (let i = 0; i < qs.length; ++i) { | ||
| 274 | 274 | const code = qs.charCodeAt(i); | |
| 275 | 275 | ||
| 276 | 276 | // Try matching key/value pair separator (e.g. '&') | |
0 commit comments