Commit cbd0be5
benchmark: fix http/simple.js benchmark
autocannon appears to have trouble recognizing URLs that contain true
or false within them. Use 0 or 1 instead to represent the same.
PR-URL: #17583
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent f7e5ab0 commit cbd0be5
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -34,7 +34,7 @@ module.exports = http.createServer(function(req, res) { | |||
| 34 | 34 | const arg = params[2]; | |
| 35 | 35 | const n_chunks = parseInt(params[3], 10); | |
| 36 | 36 | const resHow = params.length >= 5 ? params[4] : 'normal'; | |
| 37 | - const chunkedEnc = params.length >= 6 && params[5] === 'false' ? false : true; | ||
| 37 | + const chunkedEnc = params.length >= 6 && params[5] === '0' ? false : true; | ||
| 38 | 38 | var status = 200; | |
| 39 | 39 | ||
| 40 | 40 | var n, i; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,14 +8,14 @@ const bench = common.createBenchmark(main, { | |||
| 8 | 8 | len: [4, 1024, 102400], | |
| 9 | 9 | chunks: [1, 4], | |
| 10 | 10 | c: [50, 500], | |
| 11 | - chunkedEnc: ['true', 'false'], | ||
| 11 | + chunkedEnc: [1, 0], | ||
| 12 | 12 | res: ['normal', 'setHeader', 'setHeaderWH'] | |
| 13 | 13 | }); | |
| 14 | 14 | ||
| 15 | 15 | function main(conf) { | |
| 16 | 16 | process.env.PORT = PORT; | |
| 17 | 17 | var server = require('../fixtures/simple-http-server.js') | |
| 18 | - .listen(process.env.PORT || common.PORT) | ||
| 18 | + .listen(PORT) | ||
| 19 | 19 | .on('listening', function() { | |
| 20 | 20 | const path = | |
| 21 | 21 | `/${conf.type}/${conf.len}/${conf.chunks}/${conf.res}/${conf.chunkedEnc}`; | |
0 commit comments