Commit cc29696
stream: fix Writable.toWeb() desiredSize for non-object-mode
Writable.toWeb() used a plain { highWaterMark } as the queuing
strategy for non-object-mode streams, which meant no size function
was provided. The WritableStream defaulted to counting each chunk
as size 1, so desiredSize was incorrect (e.g., a 3-byte Uint8Array
was counted as size 1 instead of 3).
Add a size() function to the strategy that mirrors how the Node.js
stream computes chunk length: byteLength for typed arrays, length
for strings/buffers, falling back to 1.
Fixes: #56269
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #62986
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent d2dc6f8 commit cc29696
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -185,7 +185,12 @@ function newWritableStreamFromStreamWritable(streamWritable, options = kEmptyObj | |||
| 185 | 185 | const strategy = | |
| 186 | 186 | streamWritable.writableObjectMode ? | |
| 187 | 187 | new CountQueuingStrategy({ highWaterMark }) : | |
| 188 | - { highWaterMark }; | ||
| 188 | + { | ||
| 189 | + highWaterMark, | ||
| 190 | + size(chunk) { | ||
| 191 | + return chunk?.byteLength ?? chunk?.length ?? 1; | ||
| 192 | + }, | ||
| 193 | + }; | ||
| 189 | 194 | ||
| 190 | 195 | let controller; | |
| 191 | 196 | let backpressurePromise; | |
0 commit comments