Commit cc36db7
committed
deps: always define V8_EXPORT_PRIVATE as no-op
dllexport introduces issues when compiling with MSVC.
PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #54077
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent e945bd9 commit cc36db7
2 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.0', | ||
| 39 | + 'v8_embedder_string': '-node.1', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -401,9 +401,9 @@ bool is_inbounds(float_t v) { | |||
| 401 | 401 | // Setup for Windows shared library export. | |
| 402 | 402 | #define V8_EXPORT_ENUM | |
| 403 | 403 | #ifdef BUILDING_V8_SHARED_PRIVATE | |
| 404 | - #define V8_EXPORT_PRIVATE __declspec(dllexport) | ||
| 404 | + #define V8_EXPORT_PRIVATE | ||
| 405 | 405 | #elif USING_V8_SHARED_PRIVATE | |
| 406 | - #define V8_EXPORT_PRIVATE __declspec(dllimport) | ||
| 406 | + #define V8_EXPORT_PRIVATE | ||
| 407 | 407 | #else | |
| 408 | 408 | #define V8_EXPORT_PRIVATE | |
| 409 | 409 | #endif // BUILDING_V8_SHARED | |
@@ -413,8 +413,8 @@ bool is_inbounds(float_t v) { | |||
| 413 | 413 | // Setup for Linux shared library export. | |
| 414 | 414 | #if V8_HAS_ATTRIBUTE_VISIBILITY | |
| 415 | 415 | #ifdef BUILDING_V8_SHARED_PRIVATE | |
| 416 | - #define V8_EXPORT_PRIVATE __attribute__((visibility("default"))) | ||
| 417 | - #define V8_EXPORT_ENUM V8_EXPORT_PRIVATE | ||
| 416 | + #define V8_EXPORT_PRIVATE | ||
| 417 | + #define V8_EXPORT_ENUM | ||
| 418 | 418 | #else | |
| 419 | 419 | #define V8_EXPORT_PRIVATE | |
| 420 | 420 | #define V8_EXPORT_ENUM | |
0 commit comments