Commit cc8fcc5
test: be explicit about polluting of global
There was a comment in `test-domain-crypto.js` indicating that the
pollution of the `global` object with a `domain` property was
intentional. Provide more information in the comment so someone may
easily determine why. Use `global.domain` rather than declaring `domain`
without the `var` keyword to more clearly signal that the pollution is
intentional.
PR-URL: #6017
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 7db7a82 commit cc8fcc5
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,8 +6,9 @@ try { | |||
| 6 | 6 | return; | |
| 7 | 7 | } | |
| 8 | 8 | ||
| 9 | - // the missing var keyword is intentional | ||
| 10 | - domain = require('domain'); | ||
| 9 | + // Pollution of global is intentional as part of test. | ||
| 10 | + // See https://github.com/nodejs/node/commit/d1eff9ab | ||
| 11 | + global.domain = require('domain'); | ||
| 11 | 12 | ||
| 12 | 13 | // should not throw a 'TypeError: undefined is not a function' exception | |
| 13 | 14 | crypto.randomBytes(8); | |
0 commit comments