Commit cccd3a3
test: fix compiler warning in test_string.c
Currently, the following compiler warnings is generated:
../test_string.c:235:50: warning:
incompatible pointer types passing 'char [1]' to parameter of type
'const char16_t *' (aka 'const unsigned short *')
[-Wincompatible-pointer-types]
NAPI_CALL(env, napi_create_string_utf16(env,
"", ((size_t)INT_MAX) + 1, &output));
^~
../../common.h:50:23: note: expanded from macro 'NAPI_CALL'
NAPI_CALL_BASE(env, the_call, NULL)
^~~~~~~~
../../common.h:42:10: note: expanded from macro 'NAPI_CALL_BASE'
if ((the_call) != napi_ok) { \
^~~~~~~~
/node/src/js_native_api.h:80:66: note:
passing argument to parameter 'str' here const char16_t* str,
^
1 warning generated.
This commit adds a cast to silence this warning.
PR-URL: #26539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 0fc975d commit cccd3a3
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -232,7 +232,9 @@ static napi_value TestLargeLatin1(napi_env env, napi_callback_info info) { | |||
| 232 | 232 | static napi_value TestLargeUtf16(napi_env env, napi_callback_info info) { | |
| 233 | 233 | napi_value output; | |
| 234 | 234 | if (SIZE_MAX > INT_MAX) { | |
| 235 | - NAPI_CALL(env, napi_create_string_utf16(env, "", ((size_t)INT_MAX) + 1, &output)); | ||
| 235 | + NAPI_CALL(env, napi_create_string_utf16(env, | ||
| 236 | + ((const char16_t*)""), | ||
| 237 | + ((size_t)INT_MAX) + 1, &output)); | ||
| 236 | 238 | } else { | |
| 237 | 239 | // just throw the expected error as there is nothing to test | |
| 238 | 240 | // in this case since we can't overflow | |
0 commit comments