Revert "lib: optimize writable stream buffer clearing" · nodejs/node@ccf29cd · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ccf29cd

Browse filesBrowse the repository at this point in the historyBrowse files

ri7116

authored and

richardlau

committed

Revert "lib: optimize writable stream buffer clearing"

This reverts commit 8a2fec1. PR-URL: #59743 Reviewed-By: Mattias Buelens <mattias@buelens.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

1 parent aed1b88 commit ccf29cd
Copy full SHA for ccf29cd

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/streams
  • writable.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/streams/writable.js‎

Copy file name to clipboardExpand all lines: lib/internal/streams/writable.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -786,7 +786,7 @@ function clearBuffer(stream, state) {
786	786	if (i === buffered.length) {
787	787	resetBuffer(state);
788	788	} else if (i > 256) {
789		- state[kBufferedValue] = ArrayPrototypeSlice(buffered, i);
	789	+ buffered.splice(0, i);
790	790	state.bufferedIndex = 0;
791	791	} else {
792	792	state.bufferedIndex = i;

0 commit comments

Comments

0 (0)