Commit cd0b136
lib: fix readFile flag option typo
PR-URL: #35292
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>1 parent 9288f9d commit cd0b136
2 files changed
Lines changed: 52 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -322,7 +322,7 @@ function readFile(path, options, callback) { | |||
| 322 | 322 | return; | |
| 323 | 323 | } | |
| 324 | 324 | ||
| 325 | - const flagsNumber = stringToFlags(options.flags); | ||
| 325 | + const flagsNumber = stringToFlags(options.flag); | ||
| 326 | 326 | path = getValidatedPath(path); | |
| 327 | 327 | ||
| 328 | 328 | const req = new FSReqCallback(); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,51 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + | ||
| 3 | + // Test of fs.readFile with different flags. | ||
| 4 | + const common = require('../common'); | ||
| 5 | + const fs = require('fs'); | ||
| 6 | + const assert = require('assert'); | ||
| 7 | + const path = require('path'); | ||
| 8 | + const tmpdir = require('../common/tmpdir'); | ||
| 9 | + | ||
| 10 | + tmpdir.refresh(); | ||
| 11 | + | ||
| 12 | + { | ||
| 13 | + const emptyFile = path.join(tmpdir.path, 'empty.txt'); | ||
| 14 | + fs.closeSync(fs.openSync(emptyFile, 'w')); | ||
| 15 | + | ||
| 16 | + fs.readFile( | ||
| 17 | + emptyFile, | ||
| 18 | + // With `a+` the file is created if it does not exist | ||
| 19 | + { encoding: 'utf8', flag: 'a+' }, | ||
| 20 | + common.mustCall((err, data) => { assert.strictEqual(data, ''); }) | ||
| 21 | + ); | ||
| 22 | + | ||
| 23 | + fs.readFile( | ||
| 24 | + emptyFile, | ||
| 25 | + // Like `a+` but fails if the path exists. | ||
| 26 | + { encoding: 'utf8', flag: 'ax+' }, | ||
| 27 | + common.mustCall((err, data) => { assert.strictEqual(err.code, 'EEXIST'); }) | ||
| 28 | + ); | ||
| 29 | + } | ||
| 30 | + | ||
| 31 | + { | ||
| 32 | + const willBeCreated = path.join(tmpdir.path, 'will-be-created'); | ||
| 33 | + | ||
| 34 | + fs.readFile( | ||
| 35 | + willBeCreated, | ||
| 36 | + // With `a+` the file is created if it does not exist | ||
| 37 | + { encoding: 'utf8', flag: 'a+' }, | ||
| 38 | + common.mustCall((err, data) => { assert.strictEqual(data, ''); }) | ||
| 39 | + ); | ||
| 40 | + } | ||
| 41 | + | ||
| 42 | + { | ||
| 43 | + const willNotBeCreated = path.join(tmpdir.path, 'will-not-be-created'); | ||
| 44 | + | ||
| 45 | + fs.readFile( | ||
| 46 | + willNotBeCreated, | ||
| 47 | + // Default flag is `r`. An exception occurs if the file does not exist. | ||
| 48 | + { encoding: 'utf8' }, | ||
| 49 | + common.mustCall((err, data) => { assert.strictEqual(err.code, 'ENOENT'); }) | ||
| 50 | + ); | ||
| 51 | + } | ||
0 commit comments