util: improve performance of function areSimilarFloatArrays · nodejs/node@cd891b3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit cd891b3

Browse filesBrowse the repository at this point in the historyBrowse files

Septa2112

authored and

RafaelGSS

committed

util: improve performance of function areSimilarFloatArrays

Improve performance of areSimilarFloatArrays by using primordial. Refs: #50621 PR-URL: #51040 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 048349e commit cd891b3
Copy full SHA for cd891b3

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/util
  • comparisons.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/util/comparisons.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/comparisons.js

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -21,6 +21,7 @@ const {
21	21	StringPrototypeValueOf,
22	22	SymbolPrototypeValueOf,
23	23	TypedArrayPrototypeGetSymbolToStringTag,
	24	+ TypedArrayPrototypeGetByteLength,
24	25	Uint8Array,
25	26	} = primordials;
26	27
@@ -71,7 +72,8 @@ function areSimilarFloatArrays(a, b) {
71	72	if (a.byteLength !== b.byteLength) {
72	73	return false;
73	74	}
74		- for (let offset = 0; offset < a.byteLength; offset++) {
	75	+ const len = TypedArrayPrototypeGetByteLength(a);
	76	+ for (let offset = 0; offset < len; offset++) {
75	77	if (a[offset] !== b[offset]) {
76	78	return false;
77	79	}

0 commit comments

Comments

0 (0)