Commit cde0e5f
src: reduce unnecessary includes
A forward declaration suffices and means that the tracing
agent header and its dependencies don’t need to be included
in nearly every Node.js file.
PR-URL: #21867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>1 parent ec9d529 commit cde0e5f
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -32,7 +32,6 @@ | |||
| 32 | 32 | #include "v8.h" | |
| 33 | 33 | #include "node_perf_common.h" | |
| 34 | 34 | #include "node_context_data.h" | |
| 35 | - #include "tracing/agent.h" | ||
| 36 | 35 | #include "node_worker.h" | |
| 37 | 36 | ||
| 38 | 37 | #include <stddef.h> | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -35,7 +35,6 @@ | |||
| 35 | 35 | #include "v8.h" | |
| 36 | 36 | #include "node.h" | |
| 37 | 37 | #include "node_http2_state.h" | |
| 38 | - #include "tracing/agent.h" | ||
| 39 | 38 | ||
| 40 | 39 | #include <list> | |
| 41 | 40 | #include <stdint.h> | |
@@ -55,6 +54,10 @@ namespace performance { | |||
| 55 | 54 | class performance_state; | |
| 56 | 55 | } | |
| 57 | 56 | ||
| 57 | + namespace tracing { | ||
| 58 | + class Agent; | ||
| 59 | + } | ||
| 60 | + | ||
| 58 | 61 | namespace worker { | |
| 59 | 62 | class Worker; | |
| 60 | 63 | } | |
0 commit comments