Commit ce21fc7
test: wait for stream close before writing to file
Wait for async operations on a file to finish before writing to it
again.
This fixes flakiness in parallel/test-readline-async-iterators-destroy.
PR-URL: #30836
Fixes: #30660
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 78eaf50 commit ce21fc7
1 file changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2,6 +2,7 @@ | |||
| 2 | 2 | ||
| 3 | 3 | const common = require('../common'); | |
| 4 | 4 | const fs = require('fs'); | |
| 5 | + const { once } = require('events'); | ||
| 5 | 6 | const { join } = require('path'); | |
| 6 | 7 | const readline = require('readline'); | |
| 7 | 8 | const assert = require('assert'); | |
@@ -45,6 +46,8 @@ async function testSimpleDestroy() { | |||
| 45 | 46 | ||
| 46 | 47 | rli.close(); | |
| 47 | 48 | readable.destroy(); | |
| 49 | + | ||
| 50 | + await once(readable, 'close'); | ||
| 48 | 51 | } | |
| 49 | 52 | } | |
| 50 | 53 | ||
@@ -78,6 +81,8 @@ async function testMutualDestroy() { | |||
| 78 | 81 | ||
| 79 | 82 | rli.close(); | |
| 80 | 83 | readable.destroy(); | |
| 84 | + | ||
| 85 | + await once(readable, 'close'); | ||
| 81 | 86 | } | |
| 82 | 87 | } | |
| 83 | 88 | ||
0 commit comments