Commit ce99600
crypto: rename X509_NAME_FLAGS
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with
the naming conventions we use for constexpr values, to distinguish it
from OpenSSL's built-in X509 constants, and to clarify what specific
X509 name flags the constant represents.
PR-URL: #42001
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent 047d4de commit ce99600
1 file changed
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -42,7 +42,7 @@ using v8::Undefined; | |||
| 42 | 42 | using v8::Value; | |
| 43 | 43 | ||
| 44 | 44 | namespace crypto { | |
| 45 | - static constexpr int X509_NAME_FLAGS = | ||
| 45 | + static constexpr int kX509NameFlagsMultiline = | ||
| 46 | 46 | ASN1_STRFLGS_ESC_2253 | | |
| 47 | 47 | ASN1_STRFLGS_ESC_CTRL | | |
| 48 | 48 | ASN1_STRFLGS_UTF8_CONVERT | | |
@@ -988,7 +988,11 @@ MaybeLocal<Value> GetIssuerString( | |||
| 988 | 988 | const BIOPointer& bio, | |
| 989 | 989 | X509* cert) { | |
| 990 | 990 | X509_NAME* issuer_name = X509_get_issuer_name(cert); | |
| 991 | - if (X509_NAME_print_ex(bio.get(), issuer_name, 0, X509_NAME_FLAGS) <= 0) { | ||
| 991 | + if (X509_NAME_print_ex( | ||
| 992 | + bio.get(), | ||
| 993 | + issuer_name, | ||
| 994 | + 0, | ||
| 995 | + kX509NameFlagsMultiline) <= 0) { | ||
| 992 | 996 | USE(BIO_reset(bio.get())); | |
| 993 | 997 | return Undefined(env->isolate()); | |
| 994 | 998 | } | |
@@ -1004,7 +1008,7 @@ MaybeLocal<Value> GetSubject( | |||
| 1004 | 1008 | bio.get(), | |
| 1005 | 1009 | X509_get_subject_name(cert), | |
| 1006 | 1010 | 0, | |
| 1007 | - X509_NAME_FLAGS) <= 0) { | ||
| 1011 | + kX509NameFlagsMultiline) <= 0) { | ||
| 1008 | 1012 | USE(BIO_reset(bio.get())); | |
| 1009 | 1013 | return Undefined(env->isolate()); | |
| 1010 | 1014 | } | |
0 commit comments