Commit ceca549
test: simplify test-wasi-start-validation.js
This commit removes an extra block scope, and avoid reading
the simple.wasm file for every test case.
PR-URL: #30972
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent be3fd2e commit ceca549
1 file changed
Lines changed: 9 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,6 +6,7 @@ const assert = require('assert'); | |||
| 6 | 6 | const { WASI } = require('wasi'); | |
| 7 | 7 | ||
| 8 | 8 | const fixtures = require('../common/fixtures'); | |
| 9 | + const bufferSource = fixtures.readSync('simple.wasm'); | ||
| 9 | 10 | ||
| 10 | 11 | { | |
| 11 | 12 | const wasi = new WASI(); | |
@@ -17,23 +18,19 @@ const fixtures = require('../common/fixtures'); | |||
| 17 | 18 | ); | |
| 18 | 19 | } | |
| 19 | 20 | ||
| 20 | - { | ||
| 21 | + (async () => { | ||
| 21 | 22 | const wasi = new WASI({}); | |
| 22 | - (async () => { | ||
| 23 | - const bufferSource = fixtures.readSync('simple.wasm'); | ||
| 24 | - const wasm = await WebAssembly.compile(bufferSource); | ||
| 25 | - const instance = await WebAssembly.instantiate(wasm); | ||
| 23 | + const wasm = await WebAssembly.compile(bufferSource); | ||
| 24 | + const instance = await WebAssembly.instantiate(wasm); | ||
| 26 | 25 | ||
| 27 | - assert.throws( | ||
| 28 | - () => { wasi.start(instance); }, | ||
| 29 | - { code: 'ERR_INVALID_ARG_TYPE', message: /\bWebAssembly\.Memory\b/ } | ||
| 30 | - ); | ||
| 31 | - })(); | ||
| 32 | - } | ||
| 26 | + assert.throws( | ||
| 27 | + () => { wasi.start(instance); }, | ||
| 28 | + { code: 'ERR_INVALID_ARG_TYPE', message: /\bWebAssembly\.Memory\b/ } | ||
| 29 | + ); | ||
| 30 | + })(); | ||
| 33 | 31 | ||
| 34 | 32 | (async () => { | |
| 35 | 33 | const wasi = new WASI(); | |
| 36 | - const bufferSource = fixtures.readSync('simple.wasm'); | ||
| 37 | 34 | const wasm = await WebAssembly.compile(bufferSource); | |
| 38 | 35 | const instance = await WebAssembly.instantiate(wasm); | |
| 39 | 36 | const values = [undefined, null, 'foo', 42, true, false, () => {}]; | |
@@ -54,7 +51,6 @@ const fixtures = require('../common/fixtures'); | |||
| 54 | 51 | ||
| 55 | 52 | (async () => { | |
| 56 | 53 | const wasi = new WASI(); | |
| 57 | - const bufferSource = fixtures.readSync('simple.wasm'); | ||
| 58 | 54 | const wasm = await WebAssembly.compile(bufferSource); | |
| 59 | 55 | const instance = await WebAssembly.instantiate(wasm); | |
| 60 | 56 | ||
@@ -79,7 +75,6 @@ const fixtures = require('../common/fixtures'); | |||
| 79 | 75 | ||
| 80 | 76 | (async () => { | |
| 81 | 77 | const wasi = new WASI(); | |
| 82 | - const bufferSource = fixtures.readSync('simple.wasm'); | ||
| 83 | 78 | const wasm = await WebAssembly.compile(bufferSource); | |
| 84 | 79 | const instance = await WebAssembly.instantiate(wasm); | |
| 85 | 80 | ||
0 commit comments