Commit cef6e1c
errors: refactor invalidArgType()
`invalidArgType()` uses `includes()` in two places where `startsWith()`
and `endsWith()` are more appropriate (at least in my opinion). Switch
to those more specific functions.
PR-URL: #15544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 33760cc commit cef6e1c
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -309,7 +309,7 @@ function invalidArgType(name, expected, actual) { | |||
| 309 | 309 | ||
| 310 | 310 | // determiner: 'must be' or 'must not be' | |
| 311 | 311 | let determiner; | |
| 312 | - if (expected.includes('not ')) { | ||
| 312 | + if (typeof expected === 'string' && expected.startsWith('not ')) { | ||
| 313 | 313 | determiner = 'must not be'; | |
| 314 | 314 | expected = expected.split('not ')[1]; | |
| 315 | 315 | } else { | |
@@ -320,7 +320,7 @@ function invalidArgType(name, expected, actual) { | |||
| 320 | 320 | if (Array.isArray(name)) { | |
| 321 | 321 | var names = name.map((val) => `"${val}"`).join(', '); | |
| 322 | 322 | msg = `The ${names} arguments ${determiner} ${oneOf(expected, 'type')}`; | |
| 323 | - } else if (name.includes(' argument')) { | ||
| 323 | + } else if (name.endsWith(' argument')) { | ||
| 324 | 324 | // for the case like 'first argument' | |
| 325 | 325 | msg = `The ${name} ${determiner} ${oneOf(expected, 'type')}`; | |
| 326 | 326 | } else { | |
0 commit comments