process: check for null instead of falsy in while loop · nodejs/node@cf1d3d1 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit cf1d3d1

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

BethGriggs

committed

process: check for null instead of falsy in while loop

This prepares the code for the no-cond-assign ESLint rule. PR-URL: #41614 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent d83d55e commit cf1d3d1
Copy full SHA for cf1d3d1

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/process
  • task_queues.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/process/task_queues.js‎

Copy file name to clipboardExpand all lines: lib/internal/process/task_queues.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -68,7 +68,7 @@ function runNextTicks() {
68	68	function processTicksAndRejections() {
69	69	let tock;
70	70	do {
71		- while (tock = queue.shift()) {
	71	+ while ((tock = queue.shift()) !== null) {
72	72	const asyncId = tock[async_id_symbol];
73	73	emitBefore(asyncId, tock[trigger_async_id_symbol], tock);
74	74

0 commit comments

Comments

0 (0)