test: move common.isCPPSymbolsNotMapped to tick-processor tests · nodejs/node@d02fb36 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d02fb36

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

authored and

targos

committed

test: move common.isCPPSymbolsNotMapped to tick-processor tests

`common.isCPPSymbolsNotMapped` is used only by the tests in the `test/tick-processor` folder. Move it local to those to get it out of `common`. PR-URL: #22459 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

1 parent 9ec105c commit d02fb36
Copy full SHA for d02fb36

8 files changed

+28-19Lines changed: 28 additions & 19 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • common
    • README.md
    • index.js
    • index.mjs
  • tick-processor
    • test-tick-processor-builtin.js
    • test-tick-processor-cpp-core.js
    • test-tick-processor-polyfill-brokenfile.js
    • test-tick-processor-preprocess-flag.js
    • util.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/common/README.md‎

Copy file name to clipboardExpand all lines: test/common/README.md

-5Lines changed: 0 additions & 5 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -224,11 +224,6 @@ Platform check for Windows.
224	224
225	225	Platform check for Windows 32-bit on Windows 64-bit.
226	226
227		- ### isCPPSymbolsNotMapped
228		- * [<boolean>]
229		-
230		- Platform check for C++ symbols are mapped or not.
231		-
232	227	### leakedGlobals()
233	228	* return [<Array>]
234	229

Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js

-6Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -799,9 +799,3 @@ exports.runWithInvalidFD = function(func) {
799	799
800	800	exports.printSkipMessage('Could not generate an invalid fd');
801	801	};
802		-
803		- exports.isCPPSymbolsNotMapped = exports.isWindows ||
804		- exports.isSunOS ||
805		- exports.isAIX ||
806		- exports.isLinuxPPCBE ||
807		- exports.isFreeBSD;

Collapse file

‎test/common/index.mjs‎

Copy file name to clipboardExpand all lines: test/common/index.mjs

+2-4Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -51,8 +51,7 @@ const {
51	51	getBufferSources,
52	52	disableCrashOnUnhandledRejection,
53	53	getTTYfd,
54		- runWithInvalidFD,
55		- isCPPSymbolsNotMapped
	54	+ runWithInvalidFD
56	55	} = common;
57	56
58	57	export {
@@ -104,6 +103,5 @@ export {
104	103	getBufferSources,
105	104	disableCrashOnUnhandledRejection,
106	105	getTTYfd,
107		- runWithInvalidFD,
108		- isCPPSymbolsNotMapped
	106	+ runWithInvalidFD
109	107	};

Collapse file

‎test/tick-processor/test-tick-processor-builtin.js‎

Copy file name to clipboardExpand all lines: test/tick-processor/test-tick-processor-builtin.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,10 +1,11 @@
1	1	'use strict';
2	2	const common = require('../common');
	3	+ const { isCPPSymbolsNotMapped } = require('./util');
3	4
4	5	if (!common.enoughTestCpu)
5	6	common.skip('test is CPU-intensive');
6	7
7		- if (common.isCPPSymbolsNotMapped) {
	8	+ if (isCPPSymbolsNotMapped) {
8	9	common.skip('C++ symbols are not mapped for this os.');
9	10	}
10	11

Collapse file

‎test/tick-processor/test-tick-processor-cpp-core.js‎

Copy file name to clipboardExpand all lines: test/tick-processor/test-tick-processor-cpp-core.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,10 +1,11 @@
1	1	'use strict';
2	2	const common = require('../common');
	3	+ const { isCPPSymbolsNotMapped } = require('./util');
3	4
4	5	if (!common.enoughTestCpu)
5	6	common.skip('test is CPU-intensive');
6	7
7		- if (common.isCPPSymbolsNotMapped) {
	8	+ if (isCPPSymbolsNotMapped) {
8	9	common.skip('C++ symbols are not mapped for this os.');
9	10	}
10	11

Collapse file

‎test/tick-processor/test-tick-processor-polyfill-brokenfile.js‎

Copy file name to clipboardExpand all lines: test/tick-processor/test-tick-processor-polyfill-brokenfile.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,12 +1,13 @@
1	1	'use strict';
2	2	const common = require('../common');
	3	+ const { isCPPSymbolsNotMapped } = require('./util');
3	4	const tmpdir = require('../common/tmpdir');
4	5	tmpdir.refresh();
5	6
6	7	if (!common.enoughTestCpu)
7	8	common.skip('test is CPU-intensive');
8	9
9		- if (common.isCPPSymbolsNotMapped) {
	10	+ if (isCPPSymbolsNotMapped) {
10	11	common.skip('C++ symbols are not mapped for this OS.');
11	12	}
12	13

Collapse file

‎test/tick-processor/test-tick-processor-preprocess-flag.js‎

Copy file name to clipboardExpand all lines: test/tick-processor/test-tick-processor-preprocess-flag.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,10 +1,11 @@
1	1	'use strict';
2	2	const common = require('../common');
	3	+ const { isCPPSymbolsNotMapped } = require('./util');
3	4
4	5	if (!common.enoughTestCpu)
5	6	common.skip('test is CPU-intensive');
6	7
7		- if (common.isCPPSymbolsNotMapped) {
	8	+ if (isCPPSymbolsNotMapped) {
8	9	common.skip('C++ symbols are not mapped for this os.');
9	10	}
10	11

Collapse file

‎test/tick-processor/util.js‎

Copy file name to clipboard

+18Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,18 @@
	1	+ 'use strict';
	2	+
	3	+ // Utilities for the tick-processor tests
	4	+ const {
	5	+ isWindows,
	6	+ isSunOS,
	7	+ isAIX,
	8	+ isLinuxPPCBE,
	9	+ isFreeBSD
	10	+ } = require('../common');
	11	+
	12	+ module.exports = {
	13	+ isCPPSymbolsNotMapped: isWindows ||
	14	+ isSunOS ||
	15	+ isAIX ||
	16	+ isLinuxPPCBE ||
	17	+ isFreeBSD
	18	+ };

0 commit comments

Comments

0 (0)