Commit d05b077
test: avoid trying to call sysctl directly
sysctl is often installed in /usr/sbin, which is not conveniently
accessible to non-root. Secondly, the setting can just be read
directly from the standard location and does not need to be
parsed in any special fashion.
PR-URL: #46366
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 919e581 commit d05b077
1 file changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -24,11 +24,10 @@ const common = require('../common'); | |||
| 24 | 24 | const assert = require('assert'); | |
| 25 | 25 | const cluster = require('cluster'); | |
| 26 | 26 | const net = require('net'); | |
| 27 | - const { execSync } = require('child_process'); | ||
| 27 | + const { readFileSync } = require('fs'); | ||
| 28 | 28 | ||
| 29 | 29 | if (common.isLinux) { | |
| 30 | - const sysctlOutput = execSync('sysctl net.ipv4.ip_unprivileged_port_start').toString(); | ||
| 31 | - const unprivilegedPortStart = parseInt(sysctlOutput.split(' ')[2], 10); | ||
| 30 | + const unprivilegedPortStart = parseInt(readFileSync('/proc/sys/net/ipv4/ip_unprivileged_port_start')); | ||
| 32 | 31 | if (unprivilegedPortStart <= 42) { | |
| 33 | 32 | common.skip('Port 42 is unprivileged'); | |
| 34 | 33 | } | |
0 commit comments